From: sashiko-bot@kernel.org
To: "Henri Ommer" <henri@ommer.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F
Date: Sat, 21 Nov 2026 08:27:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-226825@kernel.org> (raw)
In-Reply-To: <20261121082404.24864-2-henri@ommer.net>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: arm: samsung: redundant word bindings in commit
subject
--
commit 53b148fe6d3224e56b6bbaff8e0921f7c5e931f2
Author: Henri Ommer <henri@ommer.net>
dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F
This commit adds the samsung,a20e compatible string for the Exynos7885
based Samsung Galaxy A20e (SM-A202F) board.
> dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F
[Severity: Low]
This isn't a bug, but the dt-bindings: prefix already indicates that the
patch adds a binding, so "bindings for" in the subject line is redundant
and can be dropped (for example, "dt-bindings: arm: samsung: Add Samsung
Galaxy A20e (SM-A202F)").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121082404.24864-1-henri@ommer.net?part=1
next prev parent reply other threads:[~2026-11-21 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 8:24 [PATCH 0/2] Add Samsung Galaxy A20e support Henri Ommer
2026-11-21 8:24 ` [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F Henri Ommer
2026-11-21 8:27 ` sashiko-bot [this message]
2026-11-21 8:24 ` [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e Henri Ommer
2026-11-21 8:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226825@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henri@ommer.net \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.