* [PATCH 0/2] Add Samsung Galaxy A20e support
@ 2026-11-21 8:24 Henri Ommer
2026-11-21 8:24 ` [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F Henri Ommer
2026-11-21 8:24 ` [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e Henri Ommer
0 siblings, 2 replies; 5+ messages in thread
From: Henri Ommer @ 2026-11-21 8:24 UTC (permalink / raw)
To: krzk+dt, peter.griffin, alim.akhtar, robh, conor+dt
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
Henri Ommer
Hi everyone,
This patch series adds a device tree and a dt-binding for the Samsung Galaxy A20e.
I verified the device boots into a LightDM login.
The device tree was tested with the device tree style checker script, which resulted in no warnings.
Signed-off-by: Henri Ommer <henri@ommer.net>
Henri Ommer (2):
dt-bindings: arm: samsung: samsung-boards: Add bindings for
a20e/SM-A202F
arm64: exynos: Add support for Samsung Galaxy A20e
.../bindings/arm/samsung/samsung-boards.yaml | 1 +
arch/arm64/boot/dts/exynos/Makefile | 1 +
.../arm64/boot/dts/exynos/exynos7885-a20e.dts | 132 ++++++++++++++++++
3 files changed, 134 insertions(+)
create mode 100644 arch/arm64/boot/dts/exynos/exynos7885-a20e.dts
--
2.56.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F 2026-11-21 8:24 [PATCH 0/2] Add Samsung Galaxy A20e support Henri Ommer @ 2026-11-21 8:24 ` Henri Ommer 2026-11-21 8:27 ` sashiko-bot 2026-11-21 8:24 ` [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e Henri Ommer 1 sibling, 1 reply; 5+ messages in thread From: Henri Ommer @ 2026-11-21 8:24 UTC (permalink / raw) To: krzk+dt, peter.griffin, alim.akhtar, robh, conor+dt Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, Henri Ommer Adds devicetree bindings for the Samsung Galaxy A20e (SM-A202F) Signed-off-by: Henri Ommer <henri@ommer.net> --- .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml index 6f3e02a63..49e9cfaca 100644 --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml @@ -227,6 +227,7 @@ properties: - description: Exynos7885 based boards items: - enum: + - samsung,a20e # Samsung Galaxy A20e (2019) - samsung,gta3xllte # Samsung Galaxy Tab A 10.1 (2019, 4G) - samsung,jackpotlte # Samsung Galaxy A8 (2018) - const: samsung,exynos7885 -- 2.56.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F 2026-11-21 8:24 ` [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F Henri Ommer @ 2026-11-21 8:27 ` sashiko-bot 0 siblings, 0 replies; 5+ messages in thread From: sashiko-bot @ 2026-11-21 8:27 UTC (permalink / raw) To: Henri Ommer; +Cc: devicetree, robh, conor+dt Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dt-bindings: arm: samsung: redundant word bindings in commit subject -- commit 53b148fe6d3224e56b6bbaff8e0921f7c5e931f2 Author: Henri Ommer <henri@ommer.net> dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F This commit adds the samsung,a20e compatible string for the Exynos7885 based Samsung Galaxy A20e (SM-A202F) board. > dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F [Severity: Low] This isn't a bug, but the dt-bindings: prefix already indicates that the patch adds a binding, so "bindings for" in the subject line is redundant and can be dropped (for example, "dt-bindings: arm: samsung: Add Samsung Galaxy A20e (SM-A202F)"). -- Sashiko AI review · https://sashiko.dev/#/patchset/20261121082404.24864-1-henri@ommer.net?part=1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e 2026-11-21 8:24 [PATCH 0/2] Add Samsung Galaxy A20e support Henri Ommer 2026-11-21 8:24 ` [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F Henri Ommer @ 2026-11-21 8:24 ` Henri Ommer 2026-11-21 8:32 ` sashiko-bot 1 sibling, 1 reply; 5+ messages in thread From: Henri Ommer @ 2026-11-21 8:24 UTC (permalink / raw) To: krzk+dt, peter.griffin, alim.akhtar, robh, conor+dt Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, Henri Ommer This initial bringup consists of - memory - internal MMC - GPIO keys (volume and power) The device boots into LightDM on Nura/postmarketOS Signed-off-by: Henri Ommer <henri@ommer.net> --- arch/arm64/boot/dts/exynos/Makefile | 1 + .../arm64/boot/dts/exynos/exynos7885-a20e.dts | 132 ++++++++++++++++++ 2 files changed, 133 insertions(+) create mode 100644 arch/arm64/boot/dts/exynos/exynos7885-a20e.dts diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile index f1946a95c..f359b5776 100644 --- a/arch/arm64/boot/dts/exynos/Makefile +++ b/arch/arm64/boot/dts/exynos/Makefile @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \ exynos7870-j6lte.dtb \ exynos7870-j7xelte.dtb \ exynos7870-on7xelte.dtb \ + exynos7885-a20e.dtb \ exynos7885-gta3xllte.dtb \ exynos7885-jackpotlte.dtb \ exynos850-a217f.dtb \ diff --git a/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts b/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts new file mode 100644 index 000000000..61f6e5c53 --- /dev/null +++ b/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts @@ -0,0 +1,132 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Samsung Galaxy A20e (a20e/SM-A202F) device tree source + * + * Copyright (c) 2026, Henri Ommer <henri@ommer.net> + */ + +/dts-v1/; +#include "exynos7885.dtsi" +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> + +/ { + model = "Samsung Galaxy A20e"; + compatible = "samsung,a20e", "samsung,exynos7885"; + chassis-type = "handset"; + + chosen { + ranges; + #address-cells = <2>; + #size-cells = <1>; + bootargs = "console=tty0 clk_ignore_unused pd_ignore_unused regulator_ignore_unused pmos.nosplash"; + + framebuffer0: framebuffer@ec000000 { + compatible = "simple-framebuffer"; + reg = <0x0 0xec000000 (720 * 1560 * 4)>; + width = <720>; + height = <1560>; + stride = <(720 * 4)>; + format = "a8r8g8b8"; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + pinctrl-0 = <&key_volup &key_voldown &key_power>; + pinctrl-names = "default"; + + power-key { + gpios = <&gpa1 7 GPIO_ACTIVE_LOW>; + label = "Power"; + wakeup-source; + linux,code = <KEY_POWER>; + }; + + voldown-key { + gpios = <&gpa1 6 GPIO_ACTIVE_LOW>; + label = "Volume Down"; + linux,code = <KEY_VOLUMEDOWN>; + }; + + volup-key { + gpios = <&gpa1 5 GPIO_ACTIVE_LOW>; + label = "Volume Up"; + linux,code = <KEY_VOLUMEUP>; + }; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x0 0x80000000 0x3bc00000>, + <0x0 0xc0000000 0x40000000>, + <0x8 0x80000000 0x3fffffff>; + }; + + reserved-memory { + ranges; + #address-cells = <2>; + #size-cells = <1>; + + cont_splash_mem: framebuffer@ec000000 { + reg = <0x0 0xec000000 (720 * 1560 * 4)>; + no-map; + }; + }; +}; + +&mmc_0 { + bus-width = <8>; + cap-mmc-highspeed; + card-detect-delay = <200>; + clock-frequency = <800000000>; + mmc-hs200-1_8v; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; + non-removable; + + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8>; + pinctrl-1 = <&sd0_clk_fast_slew_rate_1x>; + pinctrl-2 = <&sd0_clk_fast_slew_rate_2x>; + pinctrl-3 = <&sd0_clk_fast_slew_rate_3x>; + pinctrl-4 = <&sd0_clk_fast_slew_rate_4x>; + pinctrl-names = "default", + "fast-slew-rate-1x", + "fast-slew-rate-2x", + "fast-slew-rate-3x", + "fast-slew-rate-4x"; + + samsung,dw-mshc-ciu-div = <3>; + samsung,dw-mshc-ddr-timing = <2 4>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,dw-mshc-sdr-timing = <0 4>; + + status = "okay"; +}; + +&oscclk { + clock-frequency = <26000000>; +}; + +&pinctrl_alive { + key_power: key-power-pins { + samsung,pins = "gpa1-7"; + samsung,pin-function = <EXYNOS_PIN_FUNC_F>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; + }; + + key_voldown: key-voldown-pins { + samsung,pins = "gpa1-6"; + samsung,pin-function = <EXYNOS_PIN_FUNC_F>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; + }; + + key_volup: key-volup-pins { + samsung,pins = "gpa1-5"; + samsung,pin-function = <EXYNOS_PIN_FUNC_F>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; + }; +}; -- 2.56.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e 2026-11-21 8:24 ` [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e Henri Ommer @ 2026-11-21 8:32 ` sashiko-bot 0 siblings, 0 replies; 5+ messages in thread From: sashiko-bot @ 2026-11-21 8:32 UTC (permalink / raw) To: Henri Ommer; +Cc: devicetree, robh, conor+dt Thank you for your contribution! Sashiko AI review found 3 potential issues to consider: - [Medium] arm64: dts: exynos: off-by-one size 0x3fffffff in memory@80000000 node - [Medium] arm64: dts: exynos: debug and distro flags hardcoded in chosen bootargs - [Low] arm64: dts: exynos: unused downstream fast-slew-rate pinctrl in mmc_0 -- commit 3c64e215bef4d1c0f5a772e11d2129cb4345d352 Author: Henri Ommer <henri@ommer.net> arm64: exynos: Add support for Samsung Galaxy A20e This commit adds initial device tree support for the Samsung Galaxy A20e (SM-A202F) based on the Exynos 7885 SoC, covering memory, simple-framebuffer, GPIO keys, and internal eMMC. > diff --git a/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts b/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts > new file mode 100644 > index 0000000000000..61f6e5c5341cc > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos7885-a20e.dts > @@ -0,0 +1,132 @@ [ ... ] > + chosen { > + ranges; > + #address-cells = <2>; > + #size-cells = <1>; > + bootargs = "console=tty0 clk_ignore_unused pd_ignore_unused regulator_ignore_unused pmos.nosplash"; [Severity: Medium] Should clk_ignore_unused, pd_ignore_unused, regulator_ignore_unused, and pmos.nosplash be dropped from chosen/bootargs? Hardcoding the *_ignore_unused debug flags globally disables the late initcalls that gate unused clocks, power domains, and regulators across the system, and pmos.nosplash is a distribution-specific userspace option rather than a hardware description. [ ... ] > + memory@80000000 { > + device_type = "memory"; > + reg = <0x0 0x80000000 0x3bc00000>, > + <0x0 0xc0000000 0x40000000>, > + <0x8 0x80000000 0x3fffffff>; > + }; [Severity: Medium] Should the size of the third memory bank be 0x40000000 instead of 0x3fffffff? With #size-cells = <1>, the third cell is a byte size rather than an end offset. early_init_dt_add_memory_arch() masks the size with PAGE_MASK before calling memblock_add(), so 0x3fffffff rounds down and loses the final page of RAM. [ ... ] > +&mmc_0 { [ ... ] > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8>; > + pinctrl-1 = <&sd0_clk_fast_slew_rate_1x>; > + pinctrl-2 = <&sd0_clk_fast_slew_rate_2x>; > + pinctrl-3 = <&sd0_clk_fast_slew_rate_3x>; > + pinctrl-4 = <&sd0_clk_fast_slew_rate_4x>; > + pinctrl-names = "default", > + "fast-slew-rate-1x", > + "fast-slew-rate-2x", > + "fast-slew-rate-3x", > + "fast-slew-rate-4x"; [Severity: Low] Are the fast-slew-rate-1x..4x pinctrl states used by the mainline driver? Neither Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml nor dw_mmc-exynos looks up fast-slew-rate-* pinctrl states, so pinctrl-1 through pinctrl-4 are never selected. Other Exynos 7885 boards define only the "default" pinctrl state and place the desired clock drive-strength pin node directly in pinctrl-0. -- Sashiko AI review · https://sashiko.dev/#/patchset/20261121082404.24864-1-henri@ommer.net?part=2 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-21 8:32 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-21 8:24 [PATCH 0/2] Add Samsung Galaxy A20e support Henri Ommer 2026-11-21 8:24 ` [PATCH 1/2] dt-bindings: arm: samsung: samsung-boards: Add bindings for a20e/SM-A202F Henri Ommer 2026-11-21 8:27 ` sashiko-bot 2026-11-21 8:24 ` [PATCH 2/2] arm64: exynos: Add support for Samsung Galaxy A20e Henri Ommer 2026-11-21 8:32 ` sashiko-bot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.