All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: serial: pl011: Reference rs485.yaml
@ 2026-11-21 15:10 ` Kryštof Černý via B4 Relay
  0 siblings, 0 replies; 3+ messages in thread
From: Kryštof Černý @ 2026-11-21 15:10 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Lino Sanfilippo
  Cc: Matous Hybl, Miroslav Ondra, linux-kernel, linux-serial,
	devicetree, Kryštof Černý

The amba-pl011 driver supports RS-485 and parses the generic RS-485
properties with uart_get_rs485_mode(), but the binding does not allow
them. Reference rs485.yaml.

Fixes: 8d479237727c ("serial: amba-pl011: add RS485 support")

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
The PL011 driver has supported RS-485 since v5.15, added in
https://git.kernel.org/torvalds/c/8d479237727c, but dtbs_check rejects
properties such as linux,rs485-enabled-at-boot-time on PL011 nodes.
We hit this on a BCM2711 (CM4) board using two PL011 UARTs for RS-485.

An AI assistant (Claude) helped check the driver and write commit message.
---
 Documentation/devicetree/bindings/serial/pl011.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
index 3fcf2d042372..3c5f35eed04a 100644
--- a/Documentation/devicetree/bindings/serial/pl011.yaml
+++ b/Documentation/devicetree/bindings/serial/pl011.yaml
@@ -12,6 +12,7 @@ maintainers:
 allOf:
   - $ref: /schemas/arm/primecell.yaml#
   - $ref: serial.yaml#
+  - $ref: rs485.yaml#
 
 # Need a custom select here or 'arm,primecell' will match on lots of nodes
 select:

---
base-commit: 909ef7a9a30fa139e69e555e3606680f5cca7726
change-id: 20261121-pl011-rs485-6e5113a8faad

Best regards,
--  
Kryštof Černý <cleverline1mc@gmail.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] dt-bindings: serial: pl011: Reference rs485.yaml
@ 2026-11-21 15:10 ` Kryštof Černý via B4 Relay
  0 siblings, 0 replies; 3+ messages in thread
From: Kryštof Černý via B4 Relay @ 2026-11-21 15:10 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Lino Sanfilippo
  Cc: Matous Hybl, Miroslav Ondra, linux-kernel, linux-serial,
	devicetree, Kryštof Černý

From: Kryštof Černý <cleverline1mc@gmail.com>

The amba-pl011 driver supports RS-485 and parses the generic RS-485
properties with uart_get_rs485_mode(), but the binding does not allow
them. Reference rs485.yaml.

Fixes: 8d479237727c ("serial: amba-pl011: add RS485 support")

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
The PL011 driver has supported RS-485 since v5.15, added in
https://git.kernel.org/torvalds/c/8d479237727c, but dtbs_check rejects
properties such as linux,rs485-enabled-at-boot-time on PL011 nodes.
We hit this on a BCM2711 (CM4) board using two PL011 UARTs for RS-485.

An AI assistant (Claude) helped check the driver and write commit message.
---
 Documentation/devicetree/bindings/serial/pl011.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/pl011.yaml b/Documentation/devicetree/bindings/serial/pl011.yaml
index 3fcf2d042372..3c5f35eed04a 100644
--- a/Documentation/devicetree/bindings/serial/pl011.yaml
+++ b/Documentation/devicetree/bindings/serial/pl011.yaml
@@ -12,6 +12,7 @@ maintainers:
 allOf:
   - $ref: /schemas/arm/primecell.yaml#
   - $ref: serial.yaml#
+  - $ref: rs485.yaml#
 
 # Need a custom select here or 'arm,primecell' will match on lots of nodes
 select:

---
base-commit: 909ef7a9a30fa139e69e555e3606680f5cca7726
change-id: 20261121-pl011-rs485-6e5113a8faad

Best regards,
--  
Kryštof Černý <cleverline1mc@gmail.com>



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: serial: pl011: Reference rs485.yaml
  2026-11-21 15:10 ` Kryštof Černý via B4 Relay
  (?)
@ 2026-11-21 15:15 ` sashiko-bot
  -1 siblings, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-21 15:15 UTC (permalink / raw)
  To: Kryštof Černý; +Cc: linux-serial

> From: Kryštof Černý <cleverline1mc@gmail.com>
> 
> The amba-pl011 driver supports RS-485 and parses the generic RS-485
> properties with uart_get_rs485_mode(), but the binding does not allow
> them. Reference rs485.yaml.
> 
> Fixes: 8d479237727c ("serial: amba-pl011: add RS485 support")
> 
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-pl011-rs485-v1-1-0d18008f4a12@gmail.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-21 15:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21 15:10 [PATCH] dt-bindings: serial: pl011: Reference rs485.yaml Kryštof Černý
2026-11-21 15:10 ` Kryštof Černý via B4 Relay
2026-11-21 15:15 ` sashiko-bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.