From: "Jörg Sommer" <joerg@alea.gnuu.de>
To: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] Fix hardware IRQ time accounting problem.
Date: Tue, 4 Dec 2007 22:21:03 +0000 (UTC) [thread overview]
Message-ID: <slrnflbkmf.6uo.joerg@alea.gnuu.de> (raw)
In-Reply-To: 20071204055144.GR24243@bakeyournoodle.com
Hallo Tony,
Tony Breeds <tony@bakeyournoodle.com> wrote:
> The commit fa13a5a1f25f671d084d8884be96fc48d9b68275 (sched: restore
> deterministic CPU accounting on powerpc), unconditionally calls
> update_process_tick() in system context. In the deterministic accounting case
> this is the correct thing to do. However, in the non-deterministic accounting
> case we need to not do this, and results in the time accounted as hardware irq
> time being artificially elevated.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 41e13f4..b9d8837 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -350,7 +350,7 @@ struct task_struct *__switch_to(struct task_struct *prev,
> local_irq_save(flags);
>
> account_system_vtime(current);
> - account_process_tick(current, 0);
> + account_process_vtime(current);
> calculate_steal_time();
This patch works for me. The high hardware interrupt load is gone. Thanks.
Bye, Jörg.
--
Der Klügere gibt so lange nach bis er der Dumme ist.
next prev parent reply other threads:[~2007-12-04 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 5:51 [PATCH v2] Fix hardware IRQ time accounting problem Tony Breeds
2007-12-04 16:44 ` Johannes Berg
2007-12-04 16:44 ` Johannes Berg
2007-12-04 22:21 ` Jörg Sommer [this message]
2007-12-05 11:39 ` Frederik Himpe
2007-12-05 11:39 ` Frederik Himpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=slrnflbkmf.6uo.joerg@alea.gnuu.de \
--to=joerg@alea.gnuu.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.