From: Frederik Himpe <fhimpe@telenet.be>
To: linuxppc-dev@ozlabs.org
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH v2] Fix hardware IRQ time accounting problem.
Date: Wed, 5 Dec 2007 11:39:25 +0000 (UTC) [thread overview]
Message-ID: <fj62ld$6eo$1@ger.gmane.org> (raw)
In-Reply-To: 20071204055144.GR24243@bakeyournoodle.com
On Tue, 04 Dec 2007 16:51:44 +1100, Tony Breeds wrote:
> The commit fa13a5a1f25f671d084d8884be96fc48d9b68275 (sched: restore
> deterministic CPU accounting on powerpc), unconditionally calls
> update_process_tick() in system context. In the deterministic
> accounting case this is the correct thing to do. However, in the
> non-deterministic accounting case we need to not do this, and results in
> the time accounted as hardware irq time being artificially elevated.
>
> Also this patch collapses 2 consecutive '#ifdef
> CONFIG_VIRT_CPU_ACCOUNTING' checks in time.h into one for neatness.
I can confirm this patch fixed the problem for me. Thank you!
--
Frederik Himpe
WARNING: multiple messages have this Message-ID (diff)
From: Frederik Himpe <fhimpe@telenet.be>
To: linux-kernel@vger.kernel.org
Cc: linuxppc-dev@ozlabs.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH v2] Fix hardware IRQ time accounting problem.
Date: Wed, 5 Dec 2007 11:39:25 +0000 (UTC) [thread overview]
Message-ID: <fj62ld$6eo$1@ger.gmane.org> (raw)
In-Reply-To: 20071204055144.GR24243@bakeyournoodle.com
On Tue, 04 Dec 2007 16:51:44 +1100, Tony Breeds wrote:
> The commit fa13a5a1f25f671d084d8884be96fc48d9b68275 (sched: restore
> deterministic CPU accounting on powerpc), unconditionally calls
> update_process_tick() in system context. In the deterministic
> accounting case this is the correct thing to do. However, in the
> non-deterministic accounting case we need to not do this, and results in
> the time accounted as hardware irq time being artificially elevated.
>
> Also this patch collapses 2 consecutive '#ifdef
> CONFIG_VIRT_CPU_ACCOUNTING' checks in time.h into one for neatness.
I can confirm this patch fixed the problem for me. Thank you!
--
Frederik Himpe
next prev parent reply other threads:[~2007-12-05 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 5:51 [PATCH v2] Fix hardware IRQ time accounting problem Tony Breeds
2007-12-04 16:44 ` Johannes Berg
2007-12-04 16:44 ` Johannes Berg
2007-12-04 22:21 ` Jörg Sommer
2007-12-05 11:39 ` Frederik Himpe [this message]
2007-12-05 11:39 ` Frederik Himpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fj62ld$6eo$1@ger.gmane.org' \
--to=fhimpe@telenet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.