From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-devel@nongnu.org,
Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: "Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé " <philmd@linaro.org>,
"Matheus Tavares Bernardino"
<matheus.bernardino@oss.qualcomm.com>
Subject: Re: [PATCH 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading
Date: Fri, 24 Apr 2026 10:40:21 +0300 [thread overview]
Message-ID: <tdzmno.ffmka4n6ptcx@linaro.org> (raw)
In-Reply-To: <20260423213838.780814-2-pierrick.bouvier@oss.qualcomm.com>
On Fri, 24 Apr 2026 00:38, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> wrote:
>When running this on hexagon binary, we observe some undefined symbols
>without any address or size.
>
>Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
>---
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> contrib/plugins/uftrace_symbols.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
>index 02d1221228c..895fa1a6b7a 100755
>--- a/contrib/plugins/uftrace_symbols.py
>+++ b/contrib/plugins/uftrace_symbols.py
>@@ -36,8 +36,8 @@ def get_symbols(elf_file):
> out = out.strip().split('\n')
> for line in out:
> info = line.split(' ')
>- if len(info) == 3:
>- # missing size information
>+ if len(info) < 4:
>+ # missing size/address information
> continue
> addr, size, type, name = info
> # add only symbols from .text section
>--
>2.47.3
>
>
next prev parent reply other threads:[~2026-04-24 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 21:38 [PATCH 0/2] contrib/plugins/uftrace_symbols.py: fix issues to extract symbol/srcline Pierrick Bouvier
2026-04-23 21:38 ` [PATCH 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading Pierrick Bouvier
2026-04-24 7:40 ` Manos Pitsidianakis [this message]
2026-04-24 7:41 ` Manos Pitsidianakis
2026-04-24 19:18 ` Pierrick Bouvier
2026-04-24 19:21 ` Pierrick Bouvier
2026-04-23 21:38 ` [PATCH 2/2] contrib/plugins/uftrace_symbols.py: handle missing source line from addr2line Pierrick Bouvier
2026-04-24 7:43 ` Manos Pitsidianakis
2026-04-24 19:46 ` [PATCH 0/2] contrib/plugins/uftrace_symbols.py: fix issues to extract symbol/srcline Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tdzmno.ffmka4n6ptcx@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=matheus.bernardino@oss.qualcomm.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.