Re: [PATCH 1/2] contrib/plugins/uftrace_symbols.py: fix symbols reading

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

On Fri, 24 Apr 2026 00:38, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> wrote:
>When running this on hexagon binary, we observe some undefined symbols
>without any address or size.
>
>Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
>---
> contrib/plugins/uftrace_symbols.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
>index 02d1221228c..895fa1a6b7a 100755
>--- a/contrib/plugins/uftrace_symbols.py
>+++ b/contrib/plugins/uftrace_symbols.py
>@@ -36,8 +36,8 @@ def get_symbols(elf_file):
>     out = out.strip().split('\n')
>     for line in out:
>         info = line.split(' ')
>-        if len(info) == 3:
>-            # missing size information
>+        if len(info) < 4:
>+            # missing size/address information

On a second thought, shouldn't this be != 4? Otherwise the unpacking 
will fail with ValueError: too many values to unpack (expected 4)

>             continue
>         addr, size, type, name = info
>         # add only symbols from .text section
>-- 
>2.47.3
>
>