From: tip-bot for Matthias Kaehlcke <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mka@chromium.org, john.stultz@linaro.org, md@google.com,
mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
grundler@chromium.org, tglx@linutronix.de, ghackmann@google.com,
dtor@chromium.org
Subject: [tip:timers/core] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK
Date: Thu, 20 Apr 2017 06:12:55 -0700 [thread overview]
Message-ID: <tip-0773cea37470f8e080c510fe720fc356cf35df3a@git.kernel.org> (raw)
In-Reply-To: <20170418233037.70990-1-mka@chromium.org>
Commit-ID: 0773cea37470f8e080c510fe720fc356cf35df3a
Gitweb: http://git.kernel.org/tip/0773cea37470f8e080c510fe720fc356cf35df3a
Author: Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Tue, 18 Apr 2017 16:30:37 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 20 Apr 2017 14:56:58 +0200
clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK
Besides reusing existing code this removes the special case handling
for 64-bit masks, which causes clang to raise a shift count overflow
warning due to https://bugs.llvm.org//show_bug.cgi?id=10030.
Suggested-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Grant Grundler <grundler@chromium.org>
Cc: Greg Hackmann <ghackmann@google.com>
Cc: Michael Davidson <md@google.com>
Cc: John Stultz <john.stultz@linaro.org>
Link: http://lkml.kernel.org/r/20170418233037.70990-1-mka@chromium.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
include/linux/clocksource.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index cfc7584..f2b10d9 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -120,7 +120,7 @@ struct clocksource {
#define CLOCK_SOURCE_RESELECT 0x100
/* simplify initialization of mask field */
-#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
+#define CLOCKSOURCE_MASK(bits) GENMASK_ULL((bits) - 1, 0)
static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from)
{
prev parent reply other threads:[~2017-04-20 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 23:30 [PATCH v2] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Matthias Kaehlcke
2017-04-20 13:12 ` tip-bot for Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0773cea37470f8e080c510fe720fc356cf35df3a@git.kernel.org \
--to=tipbot@zytor.com \
--cc=dtor@chromium.org \
--cc=ghackmann@google.com \
--cc=grundler@chromium.org \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=md@google.com \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.