All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] msr tracing: Fix copy paste
@ 2016-06-03 18:00 Dr. David Alan Gilbert (git)
  2016-06-06 13:40 ` [tip:x86/urgent] x86/msr: Use the proper trace point conditional for writes tip-bot for Dr. David Alan Gilbert
  0 siblings, 1 reply; 2+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2016-06-03 18:00 UTC (permalink / raw)
  To: ak; +Cc: linux-kernel, x86, mingo

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The msr tracing for writes is incorrectly conditional on the read
trace.

Fixes: 7f47d8cc
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 arch/x86/include/asm/msr.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index 7dc1d8f..b5fee97 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -122,7 +122,7 @@ notrace static inline void native_write_msr(unsigned int msr,
 		     "2:\n"
 		     _ASM_EXTABLE_HANDLE(1b, 2b, ex_handler_wrmsr_unsafe)
 		     : : "c" (msr), "a"(low), "d" (high) : "memory");
-	if (msr_tracepoint_active(__tracepoint_read_msr))
+	if (msr_tracepoint_active(__tracepoint_write_msr))
 		do_trace_write_msr(msr, ((u64)high << 32 | low), 0);
 }
 
@@ -141,7 +141,7 @@ notrace static inline int native_write_msr_safe(unsigned int msr,
 		     : "c" (msr), "0" (low), "d" (high),
 		       [fault] "i" (-EIO)
 		     : "memory");
-	if (msr_tracepoint_active(__tracepoint_read_msr))
+	if (msr_tracepoint_active(__tracepoint_write_msr))
 		do_trace_write_msr(msr, ((u64)high << 32 | low), err);
 	return err;
 }
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-06 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-03 18:00 [PATCH] msr tracing: Fix copy paste Dr. David Alan Gilbert (git)
2016-06-06 13:40 ` [tip:x86/urgent] x86/msr: Use the proper trace point conditional for writes tip-bot for Dr. David Alan Gilbert

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.