* [PATCH] x86/umip: Print UMIP line only once
@ 2018-11-27 20:59 Borislav Petkov
2018-11-30 20:28 ` Ricardo Neri
2018-12-03 17:18 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
0 siblings, 2 replies; 3+ messages in thread
From: Borislav Petkov @ 2018-11-27 20:59 UTC (permalink / raw)
To: LKML; +Cc: H. Peter Anvin, Ingo Molnar, Ricardo Neri, Thomas Gleixner
From: Borislav Petkov <bp@suse.de>
... instead of issuing it per CPU and flooding dmesg unnecessarily.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/cpu/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index ffb181f959d2..2c56b8066280 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -353,7 +353,7 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c)
cr4_set_bits(X86_CR4_UMIP);
- pr_info("x86/cpu: Activated the Intel User Mode Instruction Prevention (UMIP) CPU feature\n");
+ pr_info_once("x86/cpu: Intel User Mode Instruction Prevention (UMIP) activated\n");
return;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] x86/umip: Print UMIP line only once
2018-11-27 20:59 [PATCH] x86/umip: Print UMIP line only once Borislav Petkov
@ 2018-11-30 20:28 ` Ricardo Neri
2018-12-03 17:18 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Neri @ 2018-11-30 20:28 UTC (permalink / raw)
To: Borislav Petkov; +Cc: LKML, H. Peter Anvin, Ingo Molnar, Thomas Gleixner
On Tue, Nov 27, 2018 at 09:59:36PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> ... instead of issuing it per CPU and flooding dmesg unnecessarily.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
This make sense to me. I also noticed that this message was being
printed when CPUs were put offline and the back online. There was
no need for it.
Thanks and BR,
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/cpu] x86/umip: Print UMIP line only once
2018-11-27 20:59 [PATCH] x86/umip: Print UMIP line only once Borislav Petkov
2018-11-30 20:28 ` Ricardo Neri
@ 2018-12-03 17:18 ` tip-bot for Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Borislav Petkov @ 2018-12-03 17:18 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, hpa, linux-kernel, bp, ricardo.neri-calderon, tglx, mingo
Commit-ID: 0abbbc63d0251a25d3df6c8a56ab3d3c20af082c
Gitweb: https://git.kernel.org/tip/0abbbc63d0251a25d3df6c8a56ab3d3c20af082c
Author: Borislav Petkov <bp@suse.de>
AuthorDate: Tue, 27 Nov 2018 21:54:18 +0100
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Mon, 3 Dec 2018 16:59:10 +0100
x86/umip: Print UMIP line only once
... instead of issuing it per CPU and flooding dmesg unnecessarily.
Streamline the formulation, while at it.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20181127205936.30331-1-bp@alien8.de
---
arch/x86/kernel/cpu/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index ffb181f959d2..2c56b8066280 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -353,7 +353,7 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c)
cr4_set_bits(X86_CR4_UMIP);
- pr_info("x86/cpu: Activated the Intel User Mode Instruction Prevention (UMIP) CPU feature\n");
+ pr_info_once("x86/cpu: Intel User Mode Instruction Prevention (UMIP) activated\n");
return;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-03 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-27 20:59 [PATCH] x86/umip: Print UMIP line only once Borislav Petkov
2018-11-30 20:28 ` Ricardo Neri
2018-12-03 17:18 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.