From: tip-bot for Stephen Rothwell <sfr@canb.auug.org.au>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
peterz@infradead.org, davem@davemloft.net, tglx@linutronix.de,
sfr@canb.auug.org.au, mingo@elte.hu
Subject: [tip:sched/domains] sched, sparc64: Turn cpu_coregroup_mask() into a real function
Date: Tue, 12 Apr 2011 07:40:28 GMT [thread overview]
Message-ID: <tip-3905c54f2bd2c6f937f87307987ca072eabc3e7b@git.kernel.org> (raw)
In-Reply-To: <20110412140040.3020ef55.sfr@canb.auug.org.au>
Commit-ID: 3905c54f2bd2c6f937f87307987ca072eabc3e7b
Gitweb: http://git.kernel.org/tip/3905c54f2bd2c6f937f87307987ca072eabc3e7b
Author: Stephen Rothwell <sfr@canb.auug.org.au>
AuthorDate: Tue, 12 Apr 2011 14:00:40 +1000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 12 Apr 2011 08:46:41 +0200
sched, sparc64: Turn cpu_coregroup_mask() into a real function
This compile error triggers on Sparc64:
kernel/sched.c:7140: error: 'cpu_coregroup_mask' undeclared here (not in a function)
Because after the recent scheduler domain cleanups the scheduler
uses this arch method as a function pointer in a scheduler
topology data structure - which is not possible with a macro.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20110412140040.3020ef55.sfr@canb.auug.org.au
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/sparc/include/asm/topology_64.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
index 1c79f32..8b9c556 100644
--- a/arch/sparc/include/asm/topology_64.h
+++ b/arch/sparc/include/asm/topology_64.h
@@ -65,6 +65,10 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
#define smt_capable() (sparc64_multi_core)
#endif /* CONFIG_SMP */
-#define cpu_coregroup_mask(cpu) (&cpu_core_map[cpu])
+extern cpumask_t cpu_core_map[NR_CPUS];
+static inline const struct cpumask *cpu_coregroup_mask(int cpu)
+{
+ return &cpu_core_map[cpu];
+}
#endif /* _ASM_SPARC64_TOPOLOGY_H */
prev parent reply other threads:[~2011-04-12 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 4:00 linux-next: build failure after merge of the final tree (tip tree related) Stephen Rothwell
2011-04-12 6:20 ` Ingo Molnar
2011-04-12 6:25 ` David Miller
2011-04-12 7:40 ` tip-bot for Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3905c54f2bd2c6f937f87307987ca072eabc3e7b@git.kernel.org \
--to=sfr@canb.auug.org.au \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.