From: tip-bot for Andy Lutomirski <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: luto@kernel.org, bp@alien8.de, luto@amacapital.net,
torvalds@linux-foundation.org, brgerst@gmail.com,
tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com,
dvlasenk@redhat.com, linux-kernel@vger.kernel.org,
peterz@infradead.org
Subject: [tip:x86/urgent] x86/entry/compat: Add missing CLAC to entry_INT80_32
Date: Wed, 24 Feb 2016 23:47:05 -0800 [thread overview]
Message-ID: <tip-3d44d51bd339766f0178f0cf2e8d048b4a4872aa@git.kernel.org> (raw)
In-Reply-To: <b02b7e71ae54074be01fc171cbd4b72517055c0e.1456345086.git.luto@kernel.org>
Commit-ID: 3d44d51bd339766f0178f0cf2e8d048b4a4872aa
Gitweb: http://git.kernel.org/tip/3d44d51bd339766f0178f0cf2e8d048b4a4872aa
Author: Andy Lutomirski <luto@kernel.org>
AuthorDate: Wed, 24 Feb 2016 12:18:49 -0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 25 Feb 2016 08:31:20 +0100
x86/entry/compat: Add missing CLAC to entry_INT80_32
This doesn't seem to fix a regression -- I don't think the CLAC was
ever there.
I double-checked in a debugger: entries through the int80 gate do
not automatically clear AC.
Stable maintainers: I can provide a backport to 4.3 and earlier if
needed. This needs to be backported all the way to 3.10.
Reported-by: Brian Gerst <brgerst@gmail.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: <stable@vger.kernel.org> # v3.10 and later
Fixes: 63bcff2a307b ("x86, smap: Add STAC and CLAC instructions to control user space access")
Link: http://lkml.kernel.org/r/b02b7e71ae54074be01fc171cbd4b72517055c0e.1456345086.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/entry/entry_64_compat.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index ff1c6d6..3c990ee 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -261,6 +261,7 @@ ENTRY(entry_INT80_compat)
* Interrupts are off on entry.
*/
PARAVIRT_ADJUST_EXCEPTION_FRAME
+ ASM_CLAC /* Do this early to minimize exposure */
SWAPGS
/*
next prev parent reply other threads:[~2016-02-25 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 20:18 [PATCH] x86/entry/compat: Add missing CLAC to entry_INT80_32 Andy Lutomirski
2016-02-25 7:47 ` tip-bot for Andy Lutomirski [this message]
2016-03-04 18:46 ` [3.xx-stable backport] " Kamal Mostafa
2016-03-04 22:21 ` Andy Lutomirski
2016-03-05 18:52 ` Greg Kroah-Hartman
2016-03-07 10:17 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3d44d51bd339766f0178f0cf2e8d048b4a4872aa@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.