* [PATCH v2 1/1] x86/io_apic: Make eoi_ioapic_pin() static
@ 2015-10-09 14:24 Andy Shevchenko
2015-10-11 19:12 ` [tip:x86/apic] " tip-bot for Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2015-10-09 14:24 UTC (permalink / raw)
To: linux-kernel, Thomas Gleixner, Ingo Molnar, Jiang Liu, x86
Cc: Andy Shevchenko
We have to define internally used function as static, otherwise the following
warning will be generated:
arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2:
- amend commit message
- add tag
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 5c60bb1..b5a0e3c 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
}
}
-void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
+static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
{
unsigned long flags;
struct irq_pin_list *entry;
--
2.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip:x86/apic] x86/io_apic: Make eoi_ioapic_pin() static
2015-10-09 14:24 [PATCH v2 1/1] x86/io_apic: Make eoi_ioapic_pin() static Andy Shevchenko
@ 2015-10-11 19:12 ` tip-bot for Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Andy Shevchenko @ 2015-10-11 19:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, mingo, linux-kernel, jiang.liu, andriy.shevchenko, tglx
Commit-ID: 4faefda97bc1be6ca909ba0fd0927ea78f37f67e
Gitweb: http://git.kernel.org/tip/4faefda97bc1be6ca909ba0fd0927ea78f37f67e
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Fri, 9 Oct 2015 17:24:45 +0300
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 11 Oct 2015 21:10:31 +0200
x86/io_apic: Make eoi_ioapic_pin() static
We have to define internally used function as static, otherwise the following
warning will be generated:
arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for 'eoi_ioapic_pin' [-Wmissing-prototypes]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
Link: http://lkml.kernel.org/r/1444400685-98611-1-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 5c60bb1..b5a0e3c 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
}
}
-void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
+static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
{
unsigned long flags;
struct irq_pin_list *entry;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-11 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-09 14:24 [PATCH v2 1/1] x86/io_apic: Make eoi_ioapic_pin() static Andy Shevchenko
2015-10-11 19:12 ` [tip:x86/apic] " tip-bot for Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.