* [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
@ 2014-03-04 23:15 tip-bot for Thomas Gleixner
2014-03-04 23:18 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: tip-bot for Thomas Gleixner @ 2014-03-04 23:15 UTC (permalink / raw)
To: linux-tip-commits; +Cc: shangw, peterz, hpa, tglx, linuxppc-dev, mingo
Commit-ID: 57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
Gitweb: http://git.kernel.org/tip/57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Wed, 5 Mar 2014 00:06:11 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 5 Mar 2014 00:13:33 +0100
powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
Commit b8a9a11b9 (powerpc: eeh: Kill another abuse of irq_desc) is
missing some brackets .....
It's not a good idea to write patches in grumpy mode and then forget
to at least compile test them or rely on the few eyeballs discussing
that patch to spot it.....
Reported-by: fengguang.wu@intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: ppc <linuxppc-dev@lists.ozlabs.org>
---
arch/powerpc/kernel/eeh_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
index 3e1d7de..bb61ca5 100644
--- a/arch/powerpc/kernel/eeh_driver.c
+++ b/arch/powerpc/kernel/eeh_driver.c
@@ -166,8 +166,9 @@ static void eeh_enable_irq(struct pci_dev *dev)
*
* tglx
*/
- if (irqd_irq_disabled(irq_get_irq_data(dev->irq))
+ if (irqd_irq_disabled(irq_get_irq_data(dev->irq)))
enable_irq(dev->irq);
+ }
}
/**
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
2014-03-04 23:15 [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup" tip-bot for Thomas Gleixner
@ 2014-03-04 23:18 ` Benjamin Herrenschmidt
2014-03-04 23:29 ` Thomas Gleixner
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2014-03-04 23:18 UTC (permalink / raw)
To: linux-kernel, mingo, hpa, peterz, linuxppc-dev, tglx, shangw
Cc: linux-tip-commits
On Tue, 2014-03-04 at 15:15 -0800, tip-bot for Thomas Gleixner wrote:
> Commit-ID: 57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> Gitweb: http://git.kernel.org/tip/57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> Author: Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Wed, 5 Mar 2014 00:06:11 +0100
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 5 Mar 2014 00:13:33 +0100
>
> powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
>
> Commit b8a9a11b9 (powerpc: eeh: Kill another abuse of irq_desc) is
> missing some brackets .....
>
> It's not a good idea to write patches in grumpy mode and then forget
> to at least compile test them or rely on the few eyeballs discussing
> that patch to spot it.....
Ouch :-)
Next time you have a series like that, if you want I'll throw it at my
build tester.
Cheers,
Ben.
> Reported-by: fengguang.wu@intel.com
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: ppc <linuxppc-dev@lists.ozlabs.org>
> ---
> arch/powerpc/kernel/eeh_driver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
> index 3e1d7de..bb61ca5 100644
> --- a/arch/powerpc/kernel/eeh_driver.c
> +++ b/arch/powerpc/kernel/eeh_driver.c
> @@ -166,8 +166,9 @@ static void eeh_enable_irq(struct pci_dev *dev)
> *
> * tglx
> */
> - if (irqd_irq_disabled(irq_get_irq_data(dev->irq))
> + if (irqd_irq_disabled(irq_get_irq_data(dev->irq)))
> enable_irq(dev->irq);
> + }
> }
>
> /**
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
2014-03-04 23:18 ` Benjamin Herrenschmidt
@ 2014-03-04 23:29 ` Thomas Gleixner
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2014-03-04 23:29 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: shangw, linux-tip-commits, peterz, linux-kernel, hpa,
linuxppc-dev, mingo
On Wed, 5 Mar 2014, Benjamin Herrenschmidt wrote:
> On Tue, 2014-03-04 at 15:15 -0800, tip-bot for Thomas Gleixner wrote:
> > Commit-ID: 57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> > Gitweb: http://git.kernel.org/tip/57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> > Author: Thomas Gleixner <tglx@linutronix.de>
> > AuthorDate: Wed, 5 Mar 2014 00:06:11 +0100
> > Committer: Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Wed, 5 Mar 2014 00:13:33 +0100
> >
> > powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
> >
> > Commit b8a9a11b9 (powerpc: eeh: Kill another abuse of irq_desc) is
> > missing some brackets .....
> >
> > It's not a good idea to write patches in grumpy mode and then forget
> > to at least compile test them or rely on the few eyeballs discussing
> > that patch to spot it.....
>
> Ouch :-)
>
> Next time you have a series like that, if you want I'll throw it at my
> build tester.
You simply could have been less lazy and picked up the whole ppc
related stuff instead of ignoring it....
Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
@ 2014-03-04 23:29 ` Thomas Gleixner
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2014-03-04 23:29 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: linux-kernel, mingo, hpa, peterz, linuxppc-dev, shangw,
linux-tip-commits
On Wed, 5 Mar 2014, Benjamin Herrenschmidt wrote:
> On Tue, 2014-03-04 at 15:15 -0800, tip-bot for Thomas Gleixner wrote:
> > Commit-ID: 57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> > Gitweb: http://git.kernel.org/tip/57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> > Author: Thomas Gleixner <tglx@linutronix.de>
> > AuthorDate: Wed, 5 Mar 2014 00:06:11 +0100
> > Committer: Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Wed, 5 Mar 2014 00:13:33 +0100
> >
> > powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
> >
> > Commit b8a9a11b9 (powerpc: eeh: Kill another abuse of irq_desc) is
> > missing some brackets .....
> >
> > It's not a good idea to write patches in grumpy mode and then forget
> > to at least compile test them or rely on the few eyeballs discussing
> > that patch to spot it.....
>
> Ouch :-)
>
> Next time you have a series like that, if you want I'll throw it at my
> build tester.
You simply could have been less lazy and picked up the whole ppc
related stuff instead of ignoring it....
Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-04 23:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 23:15 [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup" tip-bot for Thomas Gleixner
2014-03-04 23:18 ` Benjamin Herrenschmidt
2014-03-04 23:29 ` Thomas Gleixner
2014-03-04 23:29 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.