From: tip-bot for Attilio Rao <attilio.rao@citrix.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
konrad.wilk@oracle.com, Stefano.Stabellini@eu.citrix.com,
Ian.Campbell@citrix.com, tglx@linutronix.de,
attilio.rao@citrix.com, xen-devel@lists.xensource.com
Subject: [tip:x86/platform] x86: Remove base argument from x86_init.paging. pagetable_setup_start
Date: Wed, 12 Sep 2012 06:46:38 -0700 [thread overview]
Message-ID: <tip-73090f8993a40a2f67fed1ab866a928c68cd3765@git.kernel.org> (raw)
In-Reply-To: <1345580561-8506-2-git-send-email-attilio.rao@citrix.com>
Commit-ID: 73090f8993a40a2f67fed1ab866a928c68cd3765
Gitweb: http://git.kernel.org/tip/73090f8993a40a2f67fed1ab866a928c68cd3765
Author: Attilio Rao <attilio.rao@citrix.com>
AuthorDate: Tue, 21 Aug 2012 21:22:37 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 12 Sep 2012 15:33:06 +0200
x86: Remove base argument from x86_init.paging.pagetable_setup_start
We either use swapper_pg_dir or the argument is unused. Preparatory
patch to simplify platform pagetable setup further.
Signed-off-by: Attilio Rao <attilio.rao@citrix.com>
Ackedb-by: <konrad.wilk@oracle.com>
Cc: <Ian.Campbell@citrix.com>
Cc: <Stefano.Stabellini@eu.citrix.com>
Cc: <xen-devel@lists.xensource.com>
Link: http://lkml.kernel.org/r/1345580561-8506-2-git-send-email-attilio.rao@citrix.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/pgtable_types.h | 6 +++---
arch/x86/include/asm/x86_init.h | 2 +-
arch/x86/kernel/setup.c | 2 +-
arch/x86/kernel/x86_init.c | 3 ++-
arch/x86/mm/init_32.c | 4 ++--
arch/x86/xen/mmu.c | 2 +-
6 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
index 013286a..e02b875 100644
--- a/arch/x86/include/asm/pgtable_types.h
+++ b/arch/x86/include/asm/pgtable_types.h
@@ -303,11 +303,11 @@ void set_pte_vaddr(unsigned long vaddr, pte_t pte);
extern void native_pagetable_reserve(u64 start, u64 end);
#ifdef CONFIG_X86_32
-extern void native_pagetable_setup_start(pgd_t *base);
+extern void native_pagetable_setup_start(void);
extern void native_pagetable_setup_done(pgd_t *base);
#else
-#define native_pagetable_setup_start x86_init_pgd_noop
-#define native_pagetable_setup_done x86_init_pgd_noop
+#define native_pagetable_setup_start x86_init_pgd_start_noop
+#define native_pagetable_setup_done x86_init_pgd_done_noop
#endif
struct seq_file;
diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h
index 38155f6..782ba0c 100644
--- a/arch/x86/include/asm/x86_init.h
+++ b/arch/x86/include/asm/x86_init.h
@@ -85,7 +85,7 @@ struct x86_init_mapping {
* @pagetable_setup_done: platform specific post paging_init() call
*/
struct x86_init_paging {
- void (*pagetable_setup_start)(pgd_t *base);
+ void (*pagetable_setup_start)(void);
void (*pagetable_setup_done)(pgd_t *base);
};
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index f4b9b80..90cbbe0 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -961,7 +961,7 @@ void __init setup_arch(char **cmdline_p)
kvmclock_init();
#endif
- x86_init.paging.pagetable_setup_start(swapper_pg_dir);
+ x86_init.paging.pagetable_setup_start();
paging_init();
x86_init.paging.pagetable_setup_done(swapper_pg_dir);
diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c
index 9f3167e..3b88493 100644
--- a/arch/x86/kernel/x86_init.c
+++ b/arch/x86/kernel/x86_init.c
@@ -26,7 +26,8 @@
void __cpuinit x86_init_noop(void) { }
void __init x86_init_uint_noop(unsigned int unused) { }
-void __init x86_init_pgd_noop(pgd_t *unused) { }
+void __init x86_init_pgd_start_noop(void) { }
+void __init x86_init_pgd_done_noop(pgd_t *unused) { }
int __init iommu_init_noop(void) { return 0; }
void iommu_shutdown_noop(void) { }
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index 575d86f..c4aa1b2 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -445,10 +445,10 @@ static inline void permanent_kmaps_init(pgd_t *pgd_base)
}
#endif /* CONFIG_HIGHMEM */
-void __init native_pagetable_setup_start(pgd_t *base)
+void __init native_pagetable_setup_start(void)
{
unsigned long pfn, va;
- pgd_t *pgd;
+ pgd_t *pgd, *base = swapper_pg_dir;
pud_t *pud;
pmd_t *pmd;
pte_t *pte;
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 5141d80..32e66c8 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -1174,7 +1174,7 @@ static void xen_exit_mmap(struct mm_struct *mm)
spin_unlock(&mm->page_table_lock);
}
-static void __init xen_pagetable_setup_start(pgd_t *base)
+static void __init xen_pagetable_setup_start(void)
{
}
next prev parent reply other threads:[~2012-09-12 13:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 20:22 [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic Attilio Rao
2012-08-21 20:22 ` Attilio Rao
2012-08-21 20:22 ` [PATCH v2 1/5] X86/XEN: Remove the base argument from x86_init.paging.pagetable_setup_start Attilio Rao
2012-08-21 20:22 ` Attilio Rao
2012-09-12 13:46 ` tip-bot for Attilio Rao [this message]
2012-08-21 20:22 ` [PATCH v2 2/5] X86/XEN: Rename pagetable_setup_start() setup functions into pagetable_init() Attilio Rao
2012-08-21 20:22 ` Attilio Rao
2012-09-12 13:47 ` [tip:x86/platform] x86: Rename pagetable_setup_start() to pagetable_init() tip-bot for Attilio Rao
2012-08-21 20:22 ` [PATCH v2 3/5] X86/XEN: Allow setup function x86_init.paging.pagetable_init to setup kernel pagetables Attilio Rao
2012-08-21 20:22 ` Attilio Rao
2012-09-12 13:48 ` [tip:x86/platform] x86: Move paging_init() call to x86_init.paging .pagetable_init() tip-bot for Attilio Rao
2012-08-21 20:22 ` [PATCH v2 4/5] X86/XEN: Move content of xen_pagetable_setup_done() into xen_pagetable_init() and retire now unused x86_init.paging.pagetable_setup_done Attilio Rao
2012-08-21 20:22 ` Attilio Rao
2012-09-12 13:49 ` [tip:x86/platform] x86: xen: Cleanup and remove x86_init.paging. pagetable_setup_done() tip-bot for Attilio Rao
2012-08-21 20:22 ` [PATCH v2 5/5] X86/XEN: Add few lines explaining simple semantic for x86_init.paging.pagetable_init setup function Attilio Rao
2012-08-21 20:22 ` Attilio Rao
2012-09-12 13:50 ` [tip:x86/platform] x86: Document x86_init.paging.pagetable_init() tip-bot for Attilio Rao
2012-08-21 21:22 ` [PATCH v2 0/5] X86/XEN: Merge x86_init.paging.pagetable_setup_start and x86_init.paging.pagetable_setup_done setup functions and document its semantic Thomas Gleixner
2012-08-22 10:30 ` Stefano Stabellini
2012-08-22 13:57 ` Konrad Rzeszutek Wilk
2012-08-22 14:19 ` Thomas Gleixner
2012-08-22 14:47 ` Attilio Rao
2012-08-22 14:47 ` Attilio Rao
2012-08-23 9:28 ` [Xen-devel] " Attilio Rao
2012-08-23 13:50 ` Konrad Rzeszutek Wilk
2012-08-23 15:15 ` Thomas Gleixner
2012-08-23 15:20 ` Attilio Rao
2012-08-23 15:48 ` Thomas Gleixner
2012-09-11 12:43 ` Konrad Rzeszutek Wilk
2012-09-12 13:36 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-73090f8993a40a2f67fed1ab866a928c68cd3765@git.kernel.org \
--to=attilio.rao@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.