From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jeremy@goop.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, leigh123linux@googlemail.com,
treitmayr@devbase.at, tglx@linutronix.de
Subject: [tip:x86/urgent] x86: Use correct byte-sized register constraint in __add()
Date: Fri, 6 Apr 2012 09:53:39 -0700 [thread overview]
Message-ID: <tip-8c91c5325e107ec17e40a59a47c6517387d64eb7@git.kernel.org> (raw)
In-Reply-To: <4F7A3315.501@goop.org>
Commit-ID: 8c91c5325e107ec17e40a59a47c6517387d64eb7
Gitweb: http://git.kernel.org/tip/8c91c5325e107ec17e40a59a47c6517387d64eb7
Author: H. Peter Anvin <hpa@zytor.com>
AuthorDate: Fri, 6 Apr 2012 09:30:57 -0700
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Fri, 6 Apr 2012 09:40:07 -0700
x86: Use correct byte-sized register constraint in __add()
Similar to:
2ca052a x86: Use correct byte-sized register constraint in __xchg_op()
... the __add() macro also needs to use a "q" constraint in the
byte-sized case, lest we try to generate an illegal register.
Link: http://lkml.kernel.org/r/4F7A3315.501@goop.org
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Leigh Scott <leigh123linux@googlemail.com>
Cc: Thomas Reitmayr <treitmayr@devbase.at>
Cc: <stable@vger.kernel.org> v3.3
---
arch/x86/include/asm/cmpxchg.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/include/asm/cmpxchg.h b/arch/x86/include/asm/cmpxchg.h
index bc18d0e..99480e5 100644
--- a/arch/x86/include/asm/cmpxchg.h
+++ b/arch/x86/include/asm/cmpxchg.h
@@ -173,7 +173,7 @@ extern void __add_wrong_size(void)
switch (sizeof(*(ptr))) { \
case __X86_CASE_B: \
asm volatile (lock "addb %b1, %0\n" \
- : "+m" (*(ptr)) : "ri" (inc) \
+ : "+m" (*(ptr)) : "qi" (inc) \
: "memory", "cc"); \
break; \
case __X86_CASE_W: \
prev parent reply other threads:[~2012-04-06 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 23:15 [PATCH] Use correct byte-sized register constraint in __xchg_op() Jeremy Fitzhardinge
2012-04-04 0:37 ` Josh Boyer
2012-04-05 20:27 ` Josh Boyer
2012-04-05 21:16 ` Thomas Reitmayr
2012-04-06 7:46 ` Jeremy Fitzhardinge
2012-04-06 16:52 ` [tip:x86/urgent] x86: " tip-bot for Jeremy Fitzhardinge
2012-04-06 16:53 ` tip-bot for H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8c91c5325e107ec17e40a59a47c6517387d64eb7@git.kernel.org \
--to=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=leigh123linux@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=treitmayr@devbase.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.