* [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK
@ 2016-10-19 19:11 Alexander Kuleshov
2016-10-19 19:28 ` Borislav Petkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alexander Kuleshov @ 2016-10-19 19:11 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Ingo Molnar, H . Peter Anvin, Andy Lutomirski, Borislav Petkov,
Paolo Bonzini, linux-kernel, Alexander Kuleshov
as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
arch/x86/entry/calling.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
index 9a9e588..b493c6a 100644
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
#define SIZEOF_PTREGS 21*8
- .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
- addq $-(15*8+\addskip), %rsp
+ .macro ALLOC_PT_GPREGS_ON_STACK
+ addq $-(15*8), %rsp
.endm
.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
--
2.8.0.rc3.1353.gea9bdc0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK
2016-10-19 19:11 [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Alexander Kuleshov
@ 2016-10-19 19:28 ` Borislav Petkov
2016-10-20 9:04 ` [tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK tip-bot for Alexander Kuleshov
2016-10-20 11:07 ` [tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro tip-bot for Alexander Kuleshov
2 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2016-10-19 19:28 UTC (permalink / raw)
To: Alexander Kuleshov
Cc: Thomas Gleixner, Ingo Molnar, H . Peter Anvin, Andy Lutomirski,
Paolo Bonzini, linux-kernel
On Thu, Oct 20, 2016 at 01:11:08AM +0600, Alexander Kuleshov wrote:
> as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> arch/x86/entry/calling.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
> index 9a9e588..b493c6a 100644
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
>
> #define SIZEOF_PTREGS 21*8
>
> - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
> - addq $-(15*8+\addskip), %rsp
> + .macro ALLOC_PT_GPREGS_ON_STACK
> + addq $-(15*8), %rsp
> .endm
>
> .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
> --
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK
2016-10-19 19:11 [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Alexander Kuleshov
2016-10-19 19:28 ` Borislav Petkov
@ 2016-10-20 9:04 ` tip-bot for Alexander Kuleshov
2016-10-20 11:07 ` [tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro tip-bot for Alexander Kuleshov
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Alexander Kuleshov @ 2016-10-20 9:04 UTC (permalink / raw)
To: linux-tip-commits
Cc: pbonzini, kuleshovmail, hpa, bp, linux-kernel, tglx, mingo, luto
Commit-ID: ac679bf247cf044a5be6ca7d380307540284dd45
Gitweb: http://git.kernel.org/tip/ac679bf247cf044a5be6ca7d380307540284dd45
Author: Alexander Kuleshov <kuleshovmail@gmail.com>
AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 20 Oct 2016 10:57:37 +0200
x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK
The ALLOC_PT_GPREGS_ON_STACK macro has an optional addskip parameter, which
is not used by any usage site. Remove it.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Reviewed-by: Borislav Petkov <bp@alien8.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Link: http://lkml.kernel.org/r/20161019191108.2230-1-kuleshovmail@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/entry/calling.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
index 9a9e588..b493c6a 100644
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
#define SIZEOF_PTREGS 21*8
- .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
- addq $-(15*8+\addskip), %rsp
+ .macro ALLOC_PT_GPREGS_ON_STACK
+ addq $-(15*8), %rsp
.endm
.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro
2016-10-19 19:11 [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Alexander Kuleshov
2016-10-19 19:28 ` Borislav Petkov
2016-10-20 9:04 ` [tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK tip-bot for Alexander Kuleshov
@ 2016-10-20 11:07 ` tip-bot for Alexander Kuleshov
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Alexander Kuleshov @ 2016-10-20 11:07 UTC (permalink / raw)
To: linux-tip-commits
Cc: luto, dvlasenk, linux-kernel, peterz, torvalds, kuleshovmail, bp,
tglx, brgerst, hpa, bp, pbonzini, jpoimboe, mingo
Commit-ID: 59df2268311795ee7161776248d5288ee0841d41
Gitweb: http://git.kernel.org/tip/59df2268311795ee7161776248d5288ee0841d41
Author: Alexander Kuleshov <kuleshovmail@gmail.com>
AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 20 Oct 2016 08:42:36 +0200
x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Reviewed-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161019191108.2230-1-kuleshovmail@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/entry/calling.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
index 9a9e588..b493c6a 100644
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
#define SIZEOF_PTREGS 21*8
- .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
- addq $-(15*8+\addskip), %rsp
+ .macro ALLOC_PT_GPREGS_ON_STACK
+ addq $-(15*8), %rsp
.endm
.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-20 11:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19 19:11 [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK Alexander Kuleshov
2016-10-19 19:28 ` Borislav Petkov
2016-10-20 9:04 ` [tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK tip-bot for Alexander Kuleshov
2016-10-20 11:07 ` [tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro tip-bot for Alexander Kuleshov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.