All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	tglx@linutronix.de, mingo@elte.hu, xen-devel@lists.xensource.com,
	jeremy.fitzhardinge@citrix.com
Subject: [tip:x86/mm] x86/32: no need to use set_pte_present in set_pte_vaddr
Date: Thu, 19 Mar 2009 13:27:28 GMT	[thread overview]
Message-ID: <tip-b40c757964bbad76ecfa88eda9eb0b4d76dd8b40@git.kernel.org> (raw)
In-Reply-To: <1237406613-2929-1-git-send-email-jeremy@goop.org>

Commit-ID:  b40c757964bbad76ecfa88eda9eb0b4d76dd8b40
Gitweb:     http://git.kernel.org/tip/b40c757964bbad76ecfa88eda9eb0b4d76dd8b40
Author:     Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
AuthorDate: Wed, 18 Mar 2009 13:03:32 -0700
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 19 Mar 2009 14:04:18 +0100

x86/32: no need to use set_pte_present in set_pte_vaddr

Impact: cleanup, remove last user of set_pte_present

set_pte_vaddr() is only used to install ptes in fixmaps, and
should never be used to overwrite a present mapping.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Xen-devel <xen-devel@lists.xensource.com>
LKML-Reference: <1237406613-2929-1-git-send-email-jeremy@goop.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 arch/x86/mm/pgtable_32.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
index f2e477c..46c8834 100644
--- a/arch/x86/mm/pgtable_32.c
+++ b/arch/x86/mm/pgtable_32.c
@@ -50,7 +50,7 @@ void set_pte_vaddr(unsigned long vaddr, pte_t pteval)
 	}
 	pte = pte_offset_kernel(pmd, vaddr);
 	if (pte_val(pteval))
-		set_pte_present(&init_mm, vaddr, pte, pteval);
+		set_pte_at(&init_mm, vaddr, pte, pteval);
 	else
 		pte_clear(&init_mm, vaddr, pte);
 

WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
To: linux-tip-commits@vger.kernel.org
Cc: xen-devel@lists.xensource.com, jeremy.fitzhardinge@citrix.com,
	linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
	tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/mm] x86/32: no need to use set_pte_present in set_pte_vaddr
Date: Thu, 19 Mar 2009 13:27:28 GMT	[thread overview]
Message-ID: <tip-b40c757964bbad76ecfa88eda9eb0b4d76dd8b40@git.kernel.org> (raw)
In-Reply-To: <1237406613-2929-1-git-send-email-jeremy@goop.org>

Commit-ID:  b40c757964bbad76ecfa88eda9eb0b4d76dd8b40
Gitweb:     http://git.kernel.org/tip/b40c757964bbad76ecfa88eda9eb0b4d76dd8b40
Author:     Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
AuthorDate: Wed, 18 Mar 2009 13:03:32 -0700
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 19 Mar 2009 14:04:18 +0100

x86/32: no need to use set_pte_present in set_pte_vaddr

Impact: cleanup, remove last user of set_pte_present

set_pte_vaddr() is only used to install ptes in fixmaps, and
should never be used to overwrite a present mapping.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Xen-devel <xen-devel@lists.xensource.com>
LKML-Reference: <1237406613-2929-1-git-send-email-jeremy@goop.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 arch/x86/mm/pgtable_32.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
index f2e477c..46c8834 100644
--- a/arch/x86/mm/pgtable_32.c
+++ b/arch/x86/mm/pgtable_32.c
@@ -50,7 +50,7 @@ void set_pte_vaddr(unsigned long vaddr, pte_t pteval)
 	}
 	pte = pte_offset_kernel(pmd, vaddr);
 	if (pte_val(pteval))
-		set_pte_present(&init_mm, vaddr, pte, pteval);
+		set_pte_at(&init_mm, vaddr, pte, pteval);
 	else
 		pte_clear(&init_mm, vaddr, pte);

  parent reply	other threads:[~2009-03-19 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 20:03 [PATCH 1/2] x86/32: no need to use set_pte_present in set_pte_vaddr Jeremy Fitzhardinge
2009-03-18 20:03 ` Jeremy Fitzhardinge
2009-03-18 20:03 ` [PATCH 2/2] x86: with the last user gone, remove set_pte_present Jeremy Fitzhardinge
2009-03-18 20:03   ` Jeremy Fitzhardinge
2009-03-19 13:27   ` [tip:x86/mm] " Jeremy Fitzhardinge
2009-03-19 13:27     ` Jeremy Fitzhardinge
2009-03-19 13:27 ` Jeremy Fitzhardinge [this message]
2009-03-19 13:27   ` [tip:x86/mm] x86/32: no need to use set_pte_present in set_pte_vaddr Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-b40c757964bbad76ecfa88eda9eb0b4d76dd8b40@git.kernel.org \
    --to=jeremy.fitzhardinge@citrix.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.