All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Jeremy Fitzhardinge <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	konrad.wilk@oracle.com, jeremy@goop.org,
	raghavendra.kt@linux.vnet.ibm.com, tglx@linutronix.de,
	hpa@linux.intel.com, attilio.rao@citrix.com
Subject: [tip:x86/spinlocks] x86, ticketlock: Collapse a layer of functions
Date: Thu, 8 Aug 2013 16:19:29 -0700	[thread overview]
Message-ID: <tip-c1230bf0bf6c93ff2db93ba0b66839068f498e8b@git.kernel.org> (raw)
In-Reply-To: <20130806114120.20643.87847.sendpatchset@codeblue.in.ibm.com>

Commit-ID:  c1230bf0bf6c93ff2db93ba0b66839068f498e8b
Gitweb:     http://git.kernel.org/tip/c1230bf0bf6c93ff2db93ba0b66839068f498e8b
Author:     Jeremy Fitzhardinge <jeremy@goop.org>
AuthorDate: Tue, 6 Aug 2013 17:11:20 +0530
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Thu, 8 Aug 2013 16:06:30 -0700

x86, ticketlock: Collapse a layer of functions

Now that the paravirtualization layer doesn't exist at the spinlock
level any more, we can collapse the __ticket_ functions into the arch_
functions.

Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
Link: http://lkml.kernel.org/r/20130806114120.20643.87847.sendpatchset@codeblue.in.ibm.com
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Tested-by: Attilio Rao <attilio.rao@citrix.com>
Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/include/asm/spinlock.h | 35 +++++------------------------------
 1 file changed, 5 insertions(+), 30 deletions(-)

diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
index 4d54244..7442410 100644
--- a/arch/x86/include/asm/spinlock.h
+++ b/arch/x86/include/asm/spinlock.h
@@ -76,7 +76,7 @@ static __always_inline void __ticket_unlock_kick(struct arch_spinlock *lock,
  * in the high part, because a wide xadd increment of the low part would carry
  * up and contaminate the high part.
  */
-static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
+static __always_inline void arch_spin_lock(struct arch_spinlock *lock)
 {
 	register struct __raw_tickets inc = { .tail = 1 };
 
@@ -96,7 +96,7 @@ static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
 out:	barrier();	/* make sure nothing creeps before the lock is taken */
 }
 
-static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
+static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
 {
 	arch_spinlock_t old, new;
 
@@ -110,7 +110,7 @@ static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
 	return cmpxchg(&lock->head_tail, old.head_tail, new.head_tail) == old.head_tail;
 }
 
-static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
+static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
 {
 	__ticket_t next = lock->tickets.head + 1;
 
@@ -118,46 +118,21 @@ static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
 	__ticket_unlock_kick(lock, next);
 }
 
-static inline int __ticket_spin_is_locked(arch_spinlock_t *lock)
+static inline int arch_spin_is_locked(arch_spinlock_t *lock)
 {
 	struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
 
 	return tmp.tail != tmp.head;
 }
 
-static inline int __ticket_spin_is_contended(arch_spinlock_t *lock)
+static inline int arch_spin_is_contended(arch_spinlock_t *lock)
 {
 	struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
 
 	return (__ticket_t)(tmp.tail - tmp.head) > 1;
 }
-
-static inline int arch_spin_is_locked(arch_spinlock_t *lock)
-{
-	return __ticket_spin_is_locked(lock);
-}
-
-static inline int arch_spin_is_contended(arch_spinlock_t *lock)
-{
-	return __ticket_spin_is_contended(lock);
-}
 #define arch_spin_is_contended	arch_spin_is_contended
 
-static __always_inline void arch_spin_lock(arch_spinlock_t *lock)
-{
-	__ticket_spin_lock(lock);
-}
-
-static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
-{
-	return __ticket_spin_trylock(lock);
-}
-
-static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
-{
-	__ticket_spin_unlock(lock);
-}
-
 static __always_inline void arch_spin_lock_flags(arch_spinlock_t *lock,
 						  unsigned long flags)
 {

  reply	other threads:[~2013-08-08 23:20 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06 11:40 [PATCH V12 0/14] Paravirtualized ticket spinlocks Raghavendra K T
2013-08-06 11:40 ` Raghavendra K T
2013-08-06 11:40 ` [PATCH V12 1/14] x86/spinlock: Replace pv spinlocks with pv ticketlocks Raghavendra K T
2013-08-06 11:40   ` Raghavendra K T
2013-08-06 11:40   ` Raghavendra K T
2013-08-08 23:19   ` [tip:x86/spinlocks] x86, spinlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:41 ` [PATCH V12 2/14] x86/ticketlock: Don't inline _spin_unlock when using paravirt spinlocks Raghavendra K T
2013-08-06 11:41   ` Raghavendra K T
2013-08-06 11:41   ` Raghavendra K T
2013-08-08 23:19   ` [tip:x86/spinlocks] x86, ticketlock: Don' t " tip-bot for Raghavendra K T
2013-08-06 11:41 ` [PATCH V12 3/14] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2013-08-06 11:41   ` Raghavendra K T
2013-08-06 11:41   ` Raghavendra K T
2013-08-08 23:19   ` tip-bot for Jeremy Fitzhardinge [this message]
2013-08-06 11:41 ` [PATCH V12 4/14] xen: Defer spinlock setup until boot CPU setup Raghavendra K T
2013-08-06 11:41   ` Raghavendra K T
2013-08-06 11:41   ` Raghavendra K T
2013-08-08 23:19   ` [tip:x86/spinlocks] " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:42 ` [PATCH V12 5/14] xen/pvticketlock: Xen implementation for PV ticket locks Raghavendra K T
2013-08-06 11:42   ` Raghavendra K T
2013-08-06 11:42   ` Raghavendra K T
2013-08-08 23:19   ` [tip:x86/spinlocks] xen, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:42 ` [PATCH V12 6/14] xen/pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks Raghavendra K T
2013-08-06 11:42   ` Raghavendra K T
2013-08-06 11:42   ` Raghavendra K T
2013-08-08 23:19   ` [tip:x86/spinlocks] xen, pvticketlocks: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:42 ` [PATCH V12 7/14] x86/pvticketlock: Use callee-save for lock_spinning Raghavendra K T
2013-08-06 11:42   ` Raghavendra K T
2013-08-06 11:42   ` Raghavendra K T
2013-08-08 23:20   ` [tip:x86/spinlocks] x86, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:43 ` [PATCH V12 8/14] x86/pvticketlock: When paravirtualizing ticket locks, increment by 2 Raghavendra K T
2013-08-06 11:43   ` Raghavendra K T
2013-08-06 11:43   ` Raghavendra K T
2013-08-08 23:20   ` [tip:x86/spinlocks] x86, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:43 ` [PATCH V12 9/14] jump_label: Split out rate limiting from jump_label.h Raghavendra K T
2013-08-06 11:43   ` Raghavendra K T
2013-08-06 11:43   ` Raghavendra K T
2013-08-08 23:20   ` [tip:x86/spinlocks] " tip-bot for Andrew Jones
2013-08-06 11:43 ` [PATCH V12 10/14] x86/ticketlock: Add slowpath logic Raghavendra K T
2013-08-06 11:43   ` Raghavendra K T
2013-08-06 11:43   ` Raghavendra K T
2013-08-08 23:20   ` [tip:x86/spinlocks] x86, ticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:44 ` [PATCH V12 11/14] xen/pvticketlock: Allow interrupts to be enabled while blocking Raghavendra K T
2013-08-06 11:44   ` Raghavendra K T
2013-08-06 11:44   ` Raghavendra K T
2013-08-08 23:20   ` [tip:x86/spinlocks] xen, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:44 ` [PATCH V12 12/14] kvm uapi: Add KICK_CPU and PV_UNHALT definition to uapi Raghavendra K T
2013-08-06 11:44   ` Raghavendra K T
2013-08-06 11:44   ` Raghavendra K T
2013-08-08 23:21   ` [tip:x86/spinlocks] " tip-bot for Raghavendra K T
2013-08-06 11:45 ` [PATCH V12 13/14] kvm guest : Add configuration support to enable debug information for KVM Guests Raghavendra K T
2013-08-06 11:45   ` Raghavendra K T
2013-08-06 11:45   ` Raghavendra K T
2013-08-08 23:21   ` [tip:x86/spinlocks] " tip-bot for Srivatsa Vaddagiri
2013-08-06 11:45 ` [PATCH V12 14/14] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2013-08-06 11:45   ` Raghavendra K T
2013-08-06 11:45   ` Raghavendra K T
2013-08-08 23:21   ` [tip:x86/spinlocks] " tip-bot for Srivatsa Vaddagiri
2013-08-06 21:01 ` [PATCH V12 0/14] Paravirtualized ticket spinlocks H. Peter Anvin
2013-08-06 21:01   ` H. Peter Anvin
2013-08-07  2:54   ` Raghavendra K T
2013-08-07  2:54     ` Raghavendra K T
2013-08-07  4:48     ` H. Peter Anvin
2013-08-07  4:48       ` H. Peter Anvin
2013-08-07  6:45       ` Raghavendra K T
2013-08-07  6:45         ` Raghavendra K T
2013-08-08  0:50         ` Konrad Rzeszutek Wilk
2013-08-08  0:50           ` Konrad Rzeszutek Wilk
2013-08-08  0:50           ` Konrad Rzeszutek Wilk
2013-08-08  1:02           ` Gleb Natapov
2013-08-08  1:02             ` Gleb Natapov
2013-08-08 21:13             ` H. Peter Anvin
2013-08-08 21:13               ` H. Peter Anvin
2013-08-08 23:04               ` H. Peter Anvin
2013-08-08 23:04                 ` H. Peter Anvin
2013-08-09 12:50                 ` Raghavendra K T
2013-08-09 12:50                 ` Raghavendra K T
2013-08-09 13:00                   ` Konrad Rzeszutek Wilk
2013-08-09 13:00                     ` Konrad Rzeszutek Wilk
2013-08-09 13:14                     ` Raghavendra K T
2013-08-09 13:14                     ` Raghavendra K T
2013-08-09 14:51                     ` H. Peter Anvin
2013-08-09 14:51                       ` H. Peter Anvin
2013-08-08  2:59         ` Raghavendra K T
2013-08-08  2:59           ` Raghavendra K T
2013-08-09  1:04 ` H. Peter Anvin
2013-08-09  1:04   ` H. Peter Anvin
2013-08-09  4:28   ` Raghavendra K T
2013-08-09  4:28     ` Raghavendra K T
2013-08-09 13:09   ` Raghavendra K T
2013-08-09 13:09     ` Raghavendra K T
2013-08-09 14:20   ` Raghavendra K T
2013-08-09 14:20     ` Raghavendra K T
  -- strict thread matches above, loose matches on Subject: below --
2013-08-09 14:21 [PATCH V13 03/14] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2013-08-10 16:13 ` [tip:x86/spinlocks] x86, ticketlock: " tip-bot for Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-c1230bf0bf6c93ff2db93ba0b66839068f498e8b@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=attilio.rao@citrix.com \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.