From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: jeremy@goop.org, gregkh@suse.de, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, peterz@infradead.org,
drjones@redhat.com, virtualization@lists.linux-foundation.org,
andi@firstfloor.org, stefano.stabellini@eu.citrix.com,
xen-devel@lists.xensource.com, x86@kernel.org, mingo@redhat.com,
habanero@linux.vnet.ibm.com, riel@redhat.com,
konrad.wilk@oracle.com, ouyang@cs.pitt.edu, avi.kivity@gmail.com,
tglx@linutronix.de, chegu_vinod@hp.com,
linux-kernel@vger.kernel.org, srivatsa.vaddagiri@gmail.com,
attilio.rao@citrix.com, pbonzini@redhat.com,
torvalds@linux-foundation.org
Subject: Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks
Date: Fri, 09 Aug 2013 18:39:24 +0530 [thread overview]
Message-ID: <5204EA04.9060109@linux.vnet.ibm.com> (raw)
In-Reply-To: <52044013.3010202@zytor.com>
On 08/09/2013 06:34 AM, H. Peter Anvin wrote:
> The kbuild test bot is reporting some pretty serious errors for this
> patchset. I think these are serious enough that the patchset will need
> to be respun.
>
There were two problems:
(1) we were including spinlock_types.h in
arch/x86/include/asm/paravirt_types.h.
This was resulting in redefinition of arch_spinlock_t for non SMP kernel
solution was :
conditional inclusion of spinlock_types.h like below
#ifdef CONFIG_SMP
#include <asm/spinlock_types.h>
#else
typedef u16 __ticket_t;
#endif
(we needed __ticket_t declaration for UP)
(2) we had forward declaration of atomic_read in jumpl_label.
It was causing problem for alpha, which has macro for atomic_read
instead of static inline.
Solution was to remove forward declaration and have atomic.h included.
Peter,
the above two changes needs small changes in patch 1 and patch 9.
I 'll be resending only those two patches.
I am happy to resend the whole series if it is better and easier for
you.
WARNING: multiple messages have this Message-ID (diff)
From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: gleb@redhat.com, mingo@redhat.com, jeremy@goop.org,
x86@kernel.org, konrad.wilk@oracle.com, pbonzini@redhat.com,
linux-doc@vger.kernel.org, habanero@linux.vnet.ibm.com,
xen-devel@lists.xensource.com, peterz@infradead.org,
mtosatti@redhat.com, stefano.stabellini@eu.citrix.com,
andi@firstfloor.org, attilio.rao@citrix.com, ouyang@cs.pitt.edu,
gregkh@suse.de, agraf@suse.de, chegu_vinod@hp.com,
torvalds@linux-foundation.org, avi.kivity@gmail.com,
tglx@linutronix.de, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, riel@redhat.com,
drjones@redhat.com, virtualization@lists.linux-foundation.org,
srivatsa.vaddagiri@gmail.com
Subject: Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks
Date: Fri, 09 Aug 2013 18:39:24 +0530 [thread overview]
Message-ID: <5204EA04.9060109@linux.vnet.ibm.com> (raw)
In-Reply-To: <52044013.3010202@zytor.com>
On 08/09/2013 06:34 AM, H. Peter Anvin wrote:
> The kbuild test bot is reporting some pretty serious errors for this
> patchset. I think these are serious enough that the patchset will need
> to be respun.
>
There were two problems:
(1) we were including spinlock_types.h in
arch/x86/include/asm/paravirt_types.h.
This was resulting in redefinition of arch_spinlock_t for non SMP kernel
solution was :
conditional inclusion of spinlock_types.h like below
#ifdef CONFIG_SMP
#include <asm/spinlock_types.h>
#else
typedef u16 __ticket_t;
#endif
(we needed __ticket_t declaration for UP)
(2) we had forward declaration of atomic_read in jumpl_label.
It was causing problem for alpha, which has macro for atomic_read
instead of static inline.
Solution was to remove forward declaration and have atomic.h included.
Peter,
the above two changes needs small changes in patch 1 and patch 9.
I 'll be resending only those two patches.
I am happy to resend the whole series if it is better and easier for
you.
next prev parent reply other threads:[~2013-08-09 13:09 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 11:40 [PATCH V12 0/14] Paravirtualized ticket spinlocks Raghavendra K T
2013-08-06 11:40 ` Raghavendra K T
2013-08-06 11:40 ` [PATCH V12 1/14] x86/spinlock: Replace pv spinlocks with pv ticketlocks Raghavendra K T
2013-08-06 11:40 ` Raghavendra K T
2013-08-06 11:40 ` Raghavendra K T
2013-08-08 23:19 ` [tip:x86/spinlocks] x86, spinlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:41 ` [PATCH V12 2/14] x86/ticketlock: Don't inline _spin_unlock when using paravirt spinlocks Raghavendra K T
2013-08-06 11:41 ` Raghavendra K T
2013-08-06 11:41 ` Raghavendra K T
2013-08-08 23:19 ` [tip:x86/spinlocks] x86, ticketlock: Don' t " tip-bot for Raghavendra K T
2013-08-06 11:41 ` [PATCH V12 3/14] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2013-08-06 11:41 ` Raghavendra K T
2013-08-06 11:41 ` Raghavendra K T
2013-08-08 23:19 ` [tip:x86/spinlocks] x86, ticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:41 ` [PATCH V12 4/14] xen: Defer spinlock setup until boot CPU setup Raghavendra K T
2013-08-06 11:41 ` Raghavendra K T
2013-08-06 11:41 ` Raghavendra K T
2013-08-08 23:19 ` [tip:x86/spinlocks] " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:42 ` [PATCH V12 5/14] xen/pvticketlock: Xen implementation for PV ticket locks Raghavendra K T
2013-08-06 11:42 ` Raghavendra K T
2013-08-06 11:42 ` Raghavendra K T
2013-08-08 23:19 ` [tip:x86/spinlocks] xen, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:42 ` [PATCH V12 6/14] xen/pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks Raghavendra K T
2013-08-06 11:42 ` Raghavendra K T
2013-08-06 11:42 ` Raghavendra K T
2013-08-08 23:19 ` [tip:x86/spinlocks] xen, pvticketlocks: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:42 ` [PATCH V12 7/14] x86/pvticketlock: Use callee-save for lock_spinning Raghavendra K T
2013-08-06 11:42 ` Raghavendra K T
2013-08-06 11:42 ` Raghavendra K T
2013-08-08 23:20 ` [tip:x86/spinlocks] x86, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:43 ` [PATCH V12 8/14] x86/pvticketlock: When paravirtualizing ticket locks, increment by 2 Raghavendra K T
2013-08-06 11:43 ` Raghavendra K T
2013-08-06 11:43 ` Raghavendra K T
2013-08-08 23:20 ` [tip:x86/spinlocks] x86, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:43 ` [PATCH V12 9/14] jump_label: Split out rate limiting from jump_label.h Raghavendra K T
2013-08-06 11:43 ` Raghavendra K T
2013-08-06 11:43 ` Raghavendra K T
2013-08-08 23:20 ` [tip:x86/spinlocks] " tip-bot for Andrew Jones
2013-08-06 11:43 ` [PATCH V12 10/14] x86/ticketlock: Add slowpath logic Raghavendra K T
2013-08-06 11:43 ` Raghavendra K T
2013-08-06 11:43 ` Raghavendra K T
2013-08-08 23:20 ` [tip:x86/spinlocks] x86, ticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:44 ` [PATCH V12 11/14] xen/pvticketlock: Allow interrupts to be enabled while blocking Raghavendra K T
2013-08-06 11:44 ` Raghavendra K T
2013-08-06 11:44 ` Raghavendra K T
2013-08-08 23:20 ` [tip:x86/spinlocks] xen, pvticketlock: " tip-bot for Jeremy Fitzhardinge
2013-08-06 11:44 ` [PATCH V12 12/14] kvm uapi: Add KICK_CPU and PV_UNHALT definition to uapi Raghavendra K T
2013-08-06 11:44 ` Raghavendra K T
2013-08-06 11:44 ` Raghavendra K T
2013-08-08 23:21 ` [tip:x86/spinlocks] " tip-bot for Raghavendra K T
2013-08-06 11:45 ` [PATCH V12 13/14] kvm guest : Add configuration support to enable debug information for KVM Guests Raghavendra K T
2013-08-06 11:45 ` Raghavendra K T
2013-08-06 11:45 ` Raghavendra K T
2013-08-08 23:21 ` [tip:x86/spinlocks] " tip-bot for Srivatsa Vaddagiri
2013-08-06 11:45 ` [PATCH V12 14/14] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2013-08-06 11:45 ` Raghavendra K T
2013-08-06 11:45 ` Raghavendra K T
2013-08-08 23:21 ` [tip:x86/spinlocks] " tip-bot for Srivatsa Vaddagiri
2013-08-06 21:01 ` [PATCH V12 0/14] Paravirtualized ticket spinlocks H. Peter Anvin
2013-08-06 21:01 ` H. Peter Anvin
2013-08-07 2:54 ` Raghavendra K T
2013-08-07 2:54 ` Raghavendra K T
2013-08-07 4:48 ` H. Peter Anvin
2013-08-07 4:48 ` H. Peter Anvin
2013-08-07 6:45 ` Raghavendra K T
2013-08-07 6:45 ` Raghavendra K T
2013-08-08 0:50 ` Konrad Rzeszutek Wilk
2013-08-08 0:50 ` Konrad Rzeszutek Wilk
2013-08-08 0:50 ` Konrad Rzeszutek Wilk
2013-08-08 1:02 ` Gleb Natapov
2013-08-08 1:02 ` Gleb Natapov
2013-08-08 21:13 ` H. Peter Anvin
2013-08-08 21:13 ` H. Peter Anvin
2013-08-08 23:04 ` H. Peter Anvin
2013-08-08 23:04 ` H. Peter Anvin
2013-08-09 12:50 ` Raghavendra K T
2013-08-09 13:00 ` Konrad Rzeszutek Wilk
2013-08-09 13:00 ` Konrad Rzeszutek Wilk
2013-08-09 13:14 ` Raghavendra K T
2013-08-09 13:14 ` Raghavendra K T
2013-08-09 14:51 ` H. Peter Anvin
2013-08-09 14:51 ` H. Peter Anvin
2013-08-09 12:50 ` Raghavendra K T
2013-08-08 2:59 ` Raghavendra K T
2013-08-08 2:59 ` Raghavendra K T
2013-08-09 1:04 ` H. Peter Anvin
2013-08-09 1:04 ` H. Peter Anvin
2013-08-09 4:28 ` Raghavendra K T
2013-08-09 4:28 ` Raghavendra K T
2013-08-09 13:09 ` Raghavendra K T [this message]
2013-08-09 13:09 ` Raghavendra K T
2013-08-09 14:20 ` Raghavendra K T
2013-08-09 14:20 ` Raghavendra K T
-- strict thread matches above, loose matches on Subject: below --
2013-08-06 11:40 Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204EA04.9060109@linux.vnet.ibm.com \
--to=raghavendra.kt@linux.vnet.ibm.com \
--cc=andi@firstfloor.org \
--cc=attilio.rao@citrix.com \
--cc=avi.kivity@gmail.com \
--cc=chegu_vinod@hp.com \
--cc=drjones@redhat.com \
--cc=gregkh@suse.de \
--cc=habanero@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ouyang@cs.pitt.edu \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=srivatsa.vaddagiri@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.