* [PATCH] x86/processor: Remove unused declaration of __generic_processor_info()
@ 2017-09-11 3:43 Dou Liyang
2017-09-11 7:15 ` [tip:x86/urgent] x86/cpu: Remove unused and undefined __generic_processor_info() declaration tip-bot for Dou Liyang
0 siblings, 1 reply; 2+ messages in thread
From: Dou Liyang @ 2017-09-11 3:43 UTC (permalink / raw)
To: x86, linux-kernel; +Cc: tglx, mingo, hpa, lenb, Dou Liyang
Commit:
2b85b3d22920 ("x86/acpi: Restore the order of CPU IDs")
... reverted the __generic_processor_info() to generic_processor_info(),
but forgot to remove its declaration in mpspec.h together.
Remove the declaration and make the comments consistent.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
arch/x86/include/asm/mpspec.h | 1 -
arch/x86/kernel/apic/apic.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/mpspec.h b/arch/x86/include/asm/mpspec.h
index 831eb78..c471ca1 100644
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -86,7 +86,6 @@ static inline void e820__memblock_alloc_reserved_mpc_new(void) { }
#endif
int generic_processor_info(int apicid, int version);
-int __generic_processor_info(int apicid, int version, bool enabled);
#define PHYSID_ARRAY_SIZE BITS_TO_LONGS(MAX_LOCAL_APIC)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 8315e2f..d705c76 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -2130,7 +2130,7 @@ int generic_processor_info(int apicid, int version)
* Since fixing handling of boot_cpu_physical_apicid requires
* another discussion and tests on each platform, we leave it
* for now and here we use read_apic_id() directly in this
- * function, __generic_processor_info().
+ * function, generic_processor_info().
*/
if (disabled_cpu_apicid != BAD_APICID &&
disabled_cpu_apicid != read_apic_id() &&
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86/cpu: Remove unused and undefined __generic_processor_info() declaration
2017-09-11 3:43 [PATCH] x86/processor: Remove unused declaration of __generic_processor_info() Dou Liyang
@ 2017-09-11 7:15 ` tip-bot for Dou Liyang
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Dou Liyang @ 2017-09-11 7:15 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, mingo, peterz, linux-kernel, douly.fnst, hpa, torvalds
Commit-ID: e2329b4252f373c244e75928be38bf1dd45b35da
Gitweb: http://git.kernel.org/tip/e2329b4252f373c244e75928be38bf1dd45b35da
Author: Dou Liyang <douly.fnst@cn.fujitsu.com>
AuthorDate: Mon, 11 Sep 2017 11:43:23 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 11 Sep 2017 08:16:37 +0200
x86/cpu: Remove unused and undefined __generic_processor_info() declaration
The following revert:
2b85b3d22920 ("x86/acpi: Restore the order of CPU IDs")
... got rid of __generic_processor_info(), but forgot to remove its
declaration in mpspec.h.
Remove the declaration and update the comments as well.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: lenb@kernel.org
Link: http://lkml.kernel.org/r/1505101403-29100-1-git-send-email-douly.fnst@cn.fujitsu.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/mpspec.h | 1 -
arch/x86/kernel/apic/apic.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/mpspec.h b/arch/x86/include/asm/mpspec.h
index 831eb78..c471ca1 100644
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -86,7 +86,6 @@ static inline void e820__memblock_alloc_reserved_mpc_new(void) { }
#endif
int generic_processor_info(int apicid, int version);
-int __generic_processor_info(int apicid, int version, bool enabled);
#define PHYSID_ARRAY_SIZE BITS_TO_LONGS(MAX_LOCAL_APIC)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 7834f73..6e19ef1 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -2130,7 +2130,7 @@ int generic_processor_info(int apicid, int version)
* Since fixing handling of boot_cpu_physical_apicid requires
* another discussion and tests on each platform, we leave it
* for now and here we use read_apic_id() directly in this
- * function, __generic_processor_info().
+ * function, generic_processor_info().
*/
if (disabled_cpu_apicid != BAD_APICID &&
disabled_cpu_apicid != read_apic_id() &&
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-11 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-11 3:43 [PATCH] x86/processor: Remove unused declaration of __generic_processor_info() Dou Liyang
2017-09-11 7:15 ` [tip:x86/urgent] x86/cpu: Remove unused and undefined __generic_processor_info() declaration tip-bot for Dou Liyang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.