* [PATCH 02/10] trace_syscalls: fix SYSCALL_DEFINE0
@ 2009-12-15 7:39 Lai Jiangshan
2009-12-30 18:36 ` [tip:tracing/urgent] tracing/syscalls: Fix typo in SYSCALL_DEFINE0 tip-bot for Lai Jiangshan
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2009-12-15 7:39 UTC (permalink / raw)
To: Ingo Molnar, Steven Rostedt, Frederic Weisbecker,
Masami Hiramatsu, Jason Baron, LKML
struct syscall_metadata variable name in SYSCALL_DEFINE0
is not the same as SYSCALL_DEFINE1/2/3/4/5/6.
SYSCALL_TRACE_ENTER_EVENT() and SYSCALL_TRACE_EXIT_EVENT() expect
struct syscall_metadata's name is __syscall_meta__XXXXXX
as SYSCALL_DEFINE1/2/3/4/5/6 defines.
It causes event_enter_##sname->data points to a wrong place.
(event_enter_##sname->data points to a dummy struct syscall_metadata)
It causes syscalls which are defined by SYSCALL_DEFINE0() can not be traced.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 55e7108..bee1d41 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -196,7 +196,7 @@ struct perf_event_attr;
static const struct syscall_metadata __used \
__attribute__((__aligned__(4))) \
__attribute__((section("__syscalls_metadata"))) \
- __syscall_meta_##sname = { \
+ __syscall_meta__##sname = { \
.name = "sys_"#sname, \
.nb_args = 0, \
.enter_event = &event_enter__##sname, \
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip:tracing/urgent] tracing/syscalls: Fix typo in SYSCALL_DEFINE0
2009-12-15 7:39 [PATCH 02/10] trace_syscalls: fix SYSCALL_DEFINE0 Lai Jiangshan
@ 2009-12-30 18:36 ` tip-bot for Lai Jiangshan
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Lai Jiangshan @ 2009-12-30 18:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, fweisbec, rostedt, tglx, laijs
Commit-ID: e96dc9674cb597de4fee757ed005c8465072d13f
Gitweb: http://git.kernel.org/tip/e96dc9674cb597de4fee757ed005c8465072d13f
Author: Lai Jiangshan <laijs@cn.fujitsu.com>
AuthorDate: Tue, 15 Dec 2009 15:39:26 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Wed, 30 Dec 2009 10:27:04 -0500
tracing/syscalls: Fix typo in SYSCALL_DEFINE0
The struct syscall_metadata variable name in SYSCALL_DEFINE0
should be __syscall_meta__##sname instead of __syscall_meta_##sname
to match the name that is in SYSCALL_DEFINE1/2/3/4/5/6.
This error causes event_enter_##sname->data to point to the wrong
location, which causes syscalls which are defined by SYSCALL_DEFINE0()
not to be traced.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
LKML-Reference: <4B273D2E.1010807@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/linux/syscalls.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 65793e9..207466a 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -195,7 +195,7 @@ struct perf_event_attr;
static const struct syscall_metadata __used \
__attribute__((__aligned__(4))) \
__attribute__((section("__syscalls_metadata"))) \
- __syscall_meta_##sname = { \
+ __syscall_meta__##sname = { \
.name = "sys_"#sname, \
.nb_args = 0, \
.enter_event = &event_enter__##sname, \
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-30 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 7:39 [PATCH 02/10] trace_syscalls: fix SYSCALL_DEFINE0 Lai Jiangshan
2009-12-30 18:36 ` [tip:tracing/urgent] tracing/syscalls: Fix typo in SYSCALL_DEFINE0 tip-bot for Lai Jiangshan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.