* [PATCH] lib/stackdepot: fix obsolete comments
@ 2019-08-15 11:32 ` Miles Chen
0 siblings, 0 replies; 3+ messages in thread
From: Miles Chen @ 2019-08-15 11:32 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-kernel, linux-mediatek, wsd_upstream, Miles Chen,
Thomas Gleixner, Alexander Potapenko, Josh Poimboeuf,
Greg Kroah-Hartman, Kate Stewart
This change replaces "depot_save_stack" with "stack_depot_save"
in code comments because that depot_save_stack() is replaced by
stack_depot_save() in commit c0cfc337264c ("lib/stackdepot: Provide
functions which operate on plain storage arrays") and depot_save_stack()
is removed in commit 56d8f079c51a ("lib/stackdepot: Remove
obsolete functions")
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Alexander Potapenko <glider@google.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
lib/stackdepot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 66cab785bea0..ed717dd08ff3 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -87,7 +87,7 @@ static bool init_stack_slab(void **prealloc)
stack_slabs[depot_index + 1] = *prealloc;
/*
* This smp_store_release pairs with smp_load_acquire() from
- * |next_slab_inited| above and in depot_save_stack().
+ * |next_slab_inited| above and in stack_depot_save().
*/
smp_store_release(&next_slab_inited, 1);
}
@@ -114,7 +114,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
depot_offset = 0;
/*
* smp_store_release() here pairs with smp_load_acquire() from
- * |next_slab_inited| in depot_save_stack() and
+ * |next_slab_inited| in stack_depot_save() and
* init_stack_slab().
*/
if (depot_index + 1 < STACK_ALLOC_MAX_SLABS)
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] lib/stackdepot: fix obsolete comments
@ 2019-08-15 11:32 ` Miles Chen
0 siblings, 0 replies; 3+ messages in thread
From: Miles Chen @ 2019-08-15 11:32 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-kernel, linux-mediatek, wsd_upstream, Miles Chen,
Thomas Gleixner, Alexander Potapenko, Josh Poimboeuf,
Greg Kroah-Hartman, Kate Stewart
This change replaces "depot_save_stack" with "stack_depot_save"
in code comments because that depot_save_stack() is replaced by
stack_depot_save() in commit c0cfc337264c ("lib/stackdepot: Provide
functions which operate on plain storage arrays") and depot_save_stack()
is removed in commit 56d8f079c51a ("lib/stackdepot: Remove
obsolete functions")
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Alexander Potapenko <glider@google.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
lib/stackdepot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 66cab785bea0..ed717dd08ff3 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -87,7 +87,7 @@ static bool init_stack_slab(void **prealloc)
stack_slabs[depot_index + 1] = *prealloc;
/*
* This smp_store_release pairs with smp_load_acquire() from
- * |next_slab_inited| above and in depot_save_stack().
+ * |next_slab_inited| above and in stack_depot_save().
*/
smp_store_release(&next_slab_inited, 1);
}
@@ -114,7 +114,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
depot_offset = 0;
/*
* smp_store_release() here pairs with smp_load_acquire() from
- * |next_slab_inited| in depot_save_stack() and
+ * |next_slab_inited| in stack_depot_save() and
* init_stack_slab().
*/
if (depot_index + 1 < STACK_ALLOC_MAX_SLABS)
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:core/stacktrace] lib/stackdepot: Fix outdated comments
2019-08-15 11:32 ` Miles Chen
(?)
@ 2019-08-19 11:01 ` tip-bot for Miles Chen
-1 siblings, 0 replies; 3+ messages in thread
From: tip-bot for Miles Chen @ 2019-08-19 11:01 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, miles.chen, tglx, linux-kernel, hpa
Commit-ID: ee050dc83bc326ad5ef8ee93bca344819371e7a5
Gitweb: https://git.kernel.org/tip/ee050dc83bc326ad5ef8ee93bca344819371e7a5
Author: Miles Chen <miles.chen@mediatek.com>
AuthorDate: Thu, 15 Aug 2019 19:32:46 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 19 Aug 2019 12:57:28 +0200
lib/stackdepot: Fix outdated comments
Replace "depot_save_stack" with "stack_depot_save" in code comments because
depot_save_stack() was replaced in commit c0cfc337264c ("lib/stackdepot:
Provide functions which operate on plain storage arrays") and removed in
commit 56d8f079c51a ("lib/stackdepot: Remove obsolete functions")
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190815113246.18478-1-miles.chen@mediatek.com
---
lib/stackdepot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 66cab785bea0..ed717dd08ff3 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -87,7 +87,7 @@ static bool init_stack_slab(void **prealloc)
stack_slabs[depot_index + 1] = *prealloc;
/*
* This smp_store_release pairs with smp_load_acquire() from
- * |next_slab_inited| above and in depot_save_stack().
+ * |next_slab_inited| above and in stack_depot_save().
*/
smp_store_release(&next_slab_inited, 1);
}
@@ -114,7 +114,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
depot_offset = 0;
/*
* smp_store_release() here pairs with smp_load_acquire() from
- * |next_slab_inited| in depot_save_stack() and
+ * |next_slab_inited| in stack_depot_save() and
* init_stack_slab().
*/
if (depot_index + 1 < STACK_ALLOC_MAX_SLABS)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-19 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-15 11:32 [PATCH] lib/stackdepot: fix obsolete comments Miles Chen
2019-08-15 11:32 ` Miles Chen
2019-08-19 11:01 ` [tip:core/stacktrace] lib/stackdepot: Fix outdated comments tip-bot for Miles Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.