* [PATCH -tip] x86: pci-swiotlb.c swiotlb_dma_ops should be static
@ 2009-04-12 17:54 Jaswinder Singh Rajput
2009-04-14 0:12 ` [tip:x86/urgent] " tip-bot for Jaswinder Singh Rajput
2009-04-14 0:54 ` tip-bot for Jaswinder Singh Rajput
0 siblings, 2 replies; 4+ messages in thread
From: Jaswinder Singh Rajput @ 2009-04-12 17:54 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, LKML
Impact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
For x86: swiotlb_dma_ops can be static, because it's not used outside pci-swiotlb.c
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/pci-swiotlb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
index 887388a..a1712f2 100644
--- a/arch/x86/kernel/pci-swiotlb.c
+++ b/arch/x86/kernel/pci-swiotlb.c
@@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
return swiotlb_alloc_coherent(hwdev, size, dma_handle, flags);
}
-struct dma_map_ops swiotlb_dma_ops = {
+static struct dma_map_ops swiotlb_dma_ops = {
.mapping_error = swiotlb_dma_mapping_error,
.alloc_coherent = x86_swiotlb_alloc_coherent,
.free_coherent = swiotlb_free_coherent,
--
1.6.0.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* [tip:x86/urgent] x86: pci-swiotlb.c swiotlb_dma_ops should be static
2009-04-12 17:54 [PATCH -tip] x86: pci-swiotlb.c swiotlb_dma_ops should be static Jaswinder Singh Rajput
@ 2009-04-14 0:12 ` tip-bot for Jaswinder Singh Rajput
2009-04-14 0:49 ` FUJITA Tomonori
2009-04-14 0:54 ` tip-bot for Jaswinder Singh Rajput
1 sibling, 1 reply; 4+ messages in thread
From: tip-bot for Jaswinder Singh Rajput @ 2009-04-14 0:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, fujita.tomonori, jaswinder,
jaswinderrajput, tglx, mingo
Commit-ID: 49cc21f93ddc4c17c2be77d9da43a2db69acc0d3
Gitweb: http://git.kernel.org/tip/49cc21f93ddc4c17c2be77d9da43a2db69acc0d3
Author: Jaswinder Singh Rajput <jaswinder@kernel.org>
AuthorDate: Sun, 12 Apr 2009 23:24:21 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 14 Apr 2009 01:35:11 +0200
x86: pci-swiotlb.c swiotlb_dma_ops should be static
Impact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
For x86: swiotlb_dma_ops can be static, because it's not used outside
of pci-swiotlb.c
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
LKML-Reference: <1239558861.3938.2.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/pci-swiotlb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
index 34f12e9..221a385 100644
--- a/arch/x86/kernel/pci-swiotlb.c
+++ b/arch/x86/kernel/pci-swiotlb.c
@@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
return swiotlb_alloc_coherent(hwdev, size, dma_handle, flags);
}
-struct dma_map_ops swiotlb_dma_ops = {
+static struct dma_map_ops swiotlb_dma_ops = {
.mapping_error = swiotlb_dma_mapping_error,
.alloc_coherent = x86_swiotlb_alloc_coherent,
.free_coherent = swiotlb_free_coherent,
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [tip:x86/urgent] x86: pci-swiotlb.c swiotlb_dma_ops should be static
2009-04-14 0:12 ` [tip:x86/urgent] " tip-bot for Jaswinder Singh Rajput
@ 2009-04-14 0:49 ` FUJITA Tomonori
0 siblings, 0 replies; 4+ messages in thread
From: FUJITA Tomonori @ 2009-04-14 0:49 UTC (permalink / raw)
To: mingo, hpa, linux-kernel, jaswinder, fujita.tomonori,
jaswinderrajput, tglx, mingo
Cc: linux-tip-commits
On Tue, 14 Apr 2009 00:12:52 GMT
tip-bot for Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> Commit-ID: 49cc21f93ddc4c17c2be77d9da43a2db69acc0d3
> Gitweb: http://git.kernel.org/tip/49cc21f93ddc4c17c2be77d9da43a2db69acc0d3
> Author: Jaswinder Singh Rajput <jaswinder@kernel.org>
> AuthorDate: Sun, 12 Apr 2009 23:24:21 +0530
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Tue, 14 Apr 2009 01:35:11 +0200
>
> x86: pci-swiotlb.c swiotlb_dma_ops should be static
>
> Impact: reduce kernel size a bit, address sparse warning
>
> Addresses the problem pointed out by this sparse warning:
>
> arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
>
> For x86: swiotlb_dma_ops can be static, because it's not used outside
> of pci-swiotlb.c
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> LKML-Reference: <1239558861.3938.2.camel@localhost.localdomain>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Well, this patch is fine for now. But all the users of swiotlb uses
struct dma_map_ops now so I plan to remove the arch's dma_map_ops
swiotlb_dma_ops.
>
> ---
> arch/x86/kernel/pci-swiotlb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
> index 34f12e9..221a385 100644
> --- a/arch/x86/kernel/pci-swiotlb.c
> +++ b/arch/x86/kernel/pci-swiotlb.c
> @@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
> return swiotlb_alloc_coherent(hwdev, size, dma_handle, flags);
> }
>
> -struct dma_map_ops swiotlb_dma_ops = {
> +static struct dma_map_ops swiotlb_dma_ops = {
> .mapping_error = swiotlb_dma_mapping_error,
> .alloc_coherent = x86_swiotlb_alloc_coherent,
> .free_coherent = swiotlb_free_coherent,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86: pci-swiotlb.c swiotlb_dma_ops should be static
2009-04-12 17:54 [PATCH -tip] x86: pci-swiotlb.c swiotlb_dma_ops should be static Jaswinder Singh Rajput
2009-04-14 0:12 ` [tip:x86/urgent] " tip-bot for Jaswinder Singh Rajput
@ 2009-04-14 0:54 ` tip-bot for Jaswinder Singh Rajput
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Jaswinder Singh Rajput @ 2009-04-14 0:54 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, fujita.tomonori, jaswinder,
jaswinderrajput, tglx, mingo
Commit-ID: ff6c6fed3a8ab9b0a7b02574e095e905e89421d9
Gitweb: http://git.kernel.org/tip/ff6c6fed3a8ab9b0a7b02574e095e905e89421d9
Author: Jaswinder Singh Rajput <jaswinder@kernel.org>
AuthorDate: Sun, 12 Apr 2009 23:24:21 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 14 Apr 2009 02:51:04 +0200
x86: pci-swiotlb.c swiotlb_dma_ops should be static
Impact: reduce kernel size a bit, address sparse warning
Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
For x86: swiotlb_dma_ops can be static, because it's not used outside
of pci-swiotlb.c
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
LKML-Reference: <1239558861.3938.2.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/pci-swiotlb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
index 34f12e9..221a385 100644
--- a/arch/x86/kernel/pci-swiotlb.c
+++ b/arch/x86/kernel/pci-swiotlb.c
@@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
return swiotlb_alloc_coherent(hwdev, size, dma_handle, flags);
}
-struct dma_map_ops swiotlb_dma_ops = {
+static struct dma_map_ops swiotlb_dma_ops = {
.mapping_error = swiotlb_dma_mapping_error,
.alloc_coherent = x86_swiotlb_alloc_coherent,
.free_coherent = swiotlb_free_coherent,
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-14 0:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-12 17:54 [PATCH -tip] x86: pci-swiotlb.c swiotlb_dma_ops should be static Jaswinder Singh Rajput
2009-04-14 0:12 ` [tip:x86/urgent] " tip-bot for Jaswinder Singh Rajput
2009-04-14 0:49 ` FUJITA Tomonori
2009-04-14 0:54 ` tip-bot for Jaswinder Singh Rajput
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.