All of lore.kernel.org
 help / color / mirror / Atom feed
* [tip:perf/core] perf annotate stdio: Fix --show-total-period
@ 2017-07-26 17:21 tip-bot for Taeung Song
  0 siblings, 0 replies; only message in thread
From: tip-bot for Taeung Song @ 2017-07-26 17:21 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, acme, mliska, jolsa, tglx, linux-kernel, mingo, milian.wolff,
	treeze.taeung, namhyung

Commit-ID:  585d93c5ffccced26689e34095c0d74ef20a07d6
Gitweb:     http://git.kernel.org/tip/585d93c5ffccced26689e34095c0d74ef20a07d6
Author:     Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Fri, 21 Jul 2017 11:58:20 -0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 25 Jul 2017 11:23:36 -0300

perf annotate stdio: Fix --show-total-period

We were showing the total number of samples, not the total period as
asked by the user, fix it.

Reported-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Martin Liška <mliska@suse.cz>
Cc: Milian Wolff <milian.wolff@kdab.com>
Link: http://lkml.kernel.org/n/tip-lh2nh89rtqn5x5vbfthw6qml@git.kernel.org
Fixes: 0c4a5bcea460 ("perf annotate: Display total number of samples with --show-total-period")
[ split from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/annotate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 00e085f..004072f 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1143,7 +1143,7 @@ static int disasm_line__print(struct disasm_line *dl, struct symbol *sym, u64 st
 
 			if (symbol_conf.show_total_period)
 				color_fprintf(stdout, color, " %7" PRIu64,
-					      sample.nr_samples);
+					      sample.period);
 			else
 				color_fprintf(stdout, color, " %7.2f", percent);
 		}

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-07-26 17:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-26 17:21 [tip:perf/core] perf annotate stdio: Fix --show-total-period tip-bot for Taeung Song

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.