[U-Boot-Users] [PATCH] Make target for all ARM supplied and supported development boards - patch 007

[U-Boot-Users] [PATCH] Make target for all ARM supplied and supported development boards - patch 007

[Peter Pearse]

The attached patch provides a make target for all ARM supplied and
supported development boards.

It also ensures that all boards use the preferred mechanism for initial
setup. 

I have modified the other boards using arm cpus
	sx1
	ns9750dev
	omap1510inn
	omap1610inn
	omap2420h4
	omap5912osk
	omap730p2
to use the same mechanism.

It replaces my rejected patch 006 (thanks for the comments & suggestions
Wolfgang) which
contained an unintentional change to MAKEALL. 

The patch was made against the GIT head:-

	commit bccae9039e59ac09a776429119389a6a4e679fd7
	tree 9361bea6cc2bca3d22876433406886cfc1e359de
	parent 6ebc79211420cd856c9825cf3ade8bd6fd54fee5
	author Wolfgang Denk <wd@pollux.denx.de> Thu, 06 Oct 2005
01:50:50 +0200
	committer Wolfgang Denk <wd@pollux.denx.de> Thu, 06 Oct 2005
01:50:50 +0200

Tested with MAKEALL (unpatched ;-} ) arm.

CHANGELOG:
	Provide make target for all ARM supplied & supported development
boards
	Ensure all boards use lowlevel_init(), rather than
platformsetup().
	Patch 007 from Peter Pearse <peter.pearse@arm.com> 7th Oct 2005

Regards

Peter Pearse
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 007-tidy.patch.gz
Type: application/x-gzip
Size: 27639 bytes
Desc: 007-tidy.patch.gz
Url : http://lists.denx.de/pipermail/u-boot/attachments/20051007/ac505433/attachment.bin 

[U-Boot-Users] [PATCH] Make target for all ARM supplied and supported development boards - patch 007

[Wolfgang Denk]

In message <89A528FE6DB0FA44877BB2F05B846718032C835E@ZIPPY.Emea.Arm.com> you wrote:
> 
> The attached patch provides a make target for all ARM supplied and
> supported development boards.

Sorry, does not apply any more.

> It replaces my rejected patch 006 (thanks for the comments & suggestions
> Wolfgang) which
> contained an unintentional change to MAKEALL.=20

I rejected only the MAKEALL changes I didn't like,  but  applied  all
the rest.

> The patch was made against the GIT head:-
> 
> 	commit bccae9039e59ac09a776429119389a6a4e679fd7
> 	tree 9361bea6cc2bca3d22876433406886cfc1e359de
> 	parent 6ebc79211420cd856c9825cf3ade8bd6fd54fee5
> 	author Wolfgang Denk <wd@pollux.denx.de> Thu, 06 Oct 2005 01:50:50 +0200
> 	committer Wolfgang Denk <wd@pollux.denx.de> Thu, 06 Oct 2005 01:50:50 +0200

Sorry - HEA Dis:

	commit b8e16a3450fb9853a8b0ff617d70f1121b32c4c0
	tree 26a0c89b61db362f3a5a83525f9686459b338c99
	parent 64db4b10a532263dccd2b30c0ddb863b774ec473
	author Wolfgang Denk <wd@pollux.denx.de> Thu, 06 Oct 2005 23:44:55 +0200
	committer Wolfgang Denk <wd@pollux.denx.de> Thu, 06 Oct 2005 23:44:55 +0200

	    Cleanup

> CHANGELOG:
> 	Provide make target for all ARM supplied & supported development boards
> 	Ensure all boards use lowlevel_init(), rather than platformsetup().
> 	Patch 007 from Peter Pearse <peter.pearse@arm.com> 7th Oct 2005

Peter, you're really taxing my patience.

Can you please explain why you cannot provide the "Patch by" entry in
the format I ask you for again and again?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Whenever people agree with me, I always think I must be wrong.
- Oscar Wilde

[U-Boot-Users] Re: [PATCH] Make target for all ARM supplied and supported development boards - patch 007

[Catalin Marinas]

Wolfgang Denk <wd@denx.de> wrote:
> Can you please explain why you cannot provide the "Patch by" entry in
> the format I ask you for again and again?

A suggestion - since you are using GIT, you could automatically
generate the changelog from the patch comments and no longer keep this
file under revision control. People using GIT would just run gitk or
git log to see what has changed. For people using snapshot or
releases, you would would put the changelog in the tarball.

It's even easier if you only accept patches in text/plain format and
use GIT (or other tools on top) to automatically import the patches
from the saved e-mail (the author information being automatically
preserved).

-- 
Catalin

[U-Boot-Users] Re: [PATCH] Make target for all ARM supplied and supported development boards - patch 007

[Wolfgang Denk]

Dear Catalin,

in message <tnxbr21v0no.fsf@arm.com> you wrote:
>
> A suggestion - since you are using GIT, you could automatically
> generate the changelog from the patch comments and no longer keep this

I would still need to copy & paste the information from the  message,
and collect submitter name and date from the mail headers. I think it
is impoortant to be able to match a change to the original posting of
the submitter on the mailing list.

In this respect, the CHANGELOG entry is a condensed form of the patch
comments with additional information about  the  sugbmitter  which  I
need  in  any  case  -  no  matter  if I explicitely register it in a
CHANGELOG file or not.

> file under revision control. People using GIT would just run gitk or
> git log to see what has changed. For people using snapshot or
> releases, you would would put the changelog in the tarball.

Please note that I also continue to keep the CVS server at SF in sync
with all  development  going  on  on  the  main  branch  of  the  git
repository.  This  is another place where the CHANGELOG file comes in
handy.

> It's even easier if you only accept patches in text/plain format and
> use GIT (or other tools on top) to automatically import the patches
> from the saved e-mail (the author information being automatically
> preserved).

It would be easier for me, indeed - much easier, as I would  have  to
reject 98% of all submitted patches.

Also,  I  am  strictly  against  automatically  importing   unchecked
patches. Too many patches contain horrible nonsense and would basicly
corrupt  the repository. And if I have to process / filter the paches
anyway, then it does not make any difference if I run this command or
that one.

But thanks for the well-meant suggestion.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If the code and  the  comments  disagree,  then  both  are  probably
wrong."                                                - Norm Schryer

[U-Boot-Users] Re: [PATCH] Make target for all ARM supplied and supported development boards - patch 007

[Catalin Marinas]

Wolfgang Denk <wd@denx.de> wrote:
> in message <tnxbr21v0no.fsf@arm.com> you wrote:
>>
>> A suggestion - since you are using GIT, you could automatically
>> generate the changelog from the patch comments and no longer keep this
>
> I would still need to copy & paste the information from the  message,
> and collect submitter name and date from the mail headers. I think it
> is impoortant to be able to match a change to the original posting of
> the submitter on the mailing list.

Scripts like 'git applymbox' or 'stg import --mail' can do this
automatically. With StGIT you can even modify the patch multiple times
before you decide to permanently store it in your repository.

> In this respect, the CHANGELOG entry is a condensed form of the patch
> comments with additional information about  the  sugbmitter  which  I
> need  in  any  case  -  no  matter  if I explicitely register it in a
> CHANGELOG file or not.
[...]
> Please note that I also continue to keep the CVS server at SF in sync
> with all  development  going  on  on  the  main  branch  of  the  git
> repository.  This  is another place where the CHANGELOG file comes in
> handy.

You have a pre-commit hook in GIT which you can use to automatically
append part of the patch description and author to the changelog file
(like for Linux, you can ask people to have a short description on the
first line or two, followed by an empty line and followed by a longer
description).

> Also,  I  am  strictly  against  automatically  importing   unchecked
> patches. Too many patches contain horrible nonsense and would basicly
> corrupt  the repository. And if I have to process / filter the paches
> anyway, then it does not make any difference if I run this command or
> that one.

Nobody prevents you from looking at the patch before applying it, or
for applying it on a development branch and just moving it to the
stable one (or just temporary applying them with StGIT and, if they
prove to be OK, 'stg commit' to store them permanently).

> But thanks for the well-meant suggestion.

All that matters is how you are used to work, it's pretty hard to
change the work-flow after using it for years. Anyway, in case you
want to automate the patch importing, I can help you with some
scripts (or StGIT advice).

Regards,

-- 
Catalin

[U-Boot-Users] Re: [PATCH] Make target for all ARM supplied and supported development boards - patch 007

[Wolfgang Denk]

In message <tnxirw5ybde.fsf@arm.com> you wrote:
>
> Scripts like 'git applymbox' or 'stg import --mail' can do this
> automatically. With StGIT you can even modify the patch multiple times

Yes, I know. And it works fine if  the  submitted  patchs  follow  th
required conventions. But it is no exception here to receive a base64
encoded  file  "patch.bz2"  which  turns out to be a bzip2-compressed
_tarball_ containing the patch plus eventually other files  like  the
CHANGELOG entry.

As mentioned before: either I have to reject 90...95% of all  patches
because  they cannot be processed automatically, or I have to do this
stuff manually.

> You have a pre-commit hook in GIT which you can use to automatically
> append part of the patch description and author to the changelog file

Yes, I know that such options exist, but I have to admit that  I  did
not understand the documentation:

	The default pre-commit hook, when enabled, catches introduction
	of lines with trailing whitespaces and aborts the commit when
	a such line is found.

?

> (like for Linux, you can ask people to have a short description on the
> first line or two, followed by an empty line and followed by a longer
> description).

"I can call spirits from the vasty deep."
"Why so can I, or so can any man; but will they come when you do call
for them?"          - Shakespeare, 1 King Henry IV, Act III, Scene I.

I mean: as long as we cannot have  people  understand  the  requested
CHANGELOG  entry  format (if they include such an entry at all), what
is the chance that they will do what we ask for? :-(

> All that matters is how you are used to work, it's pretty hard to
> change the work-flow after using it for years. Anyway, in case you

Indeed.

> want to automate the patch importing, I can help you with some
> scripts (or StGIT advice).

I will certainly have to look into StGIT again. 

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
News is what a chap who doesn't care much  about  anything  wants  to
read. And it's only news until he's read it. After that it's dead.
                           - Evelyn Waugh _Scoop_ (1938) bk. 1, ch. 5