* [PATCH] s390/maccess: use proper PTE accessors for copying old memory
@ 2026-07-20 14:47 Alexander Gordeev
2026-07-20 14:51 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alexander Gordeev @ 2026-07-20 14:47 UTC (permalink / raw)
To: Vasily Gorbik, Gerald Schaefer, Heiko Carstens; +Cc: linux-s390, linux-kernel
Follow the pattern established by commit c33c794828f2 ("mm:
ptep_get() conversion") and use proper PTE accessors instead
of a direct pointer dereference in memcpy_real_iter().
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
---
arch/s390/mm/maccess.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/mm/maccess.c b/arch/s390/mm/maccess.c
index cfd219fe495c..f39968dd8063 100644
--- a/arch/s390/mm/maccess.c
+++ b/arch/s390/mm/maccess.c
@@ -96,7 +96,7 @@ size_t memcpy_real_iter(struct iov_iter *iter, unsigned long src, size_t count)
pte = mk_pte_phys(phys, PAGE_KERNEL_RO);
mutex_lock(&memcpy_real_mutex);
- if (pte_val(pte) != pte_val(*memcpy_real_ptep)) {
+ if (pte_val(pte) != pte_val(ptep_get(memcpy_real_ptep))) {
__ptep_ipte(__memcpy_real_area, memcpy_real_ptep, 0, 0, IPTE_GLOBAL);
set_pte(memcpy_real_ptep, pte);
}
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] s390/maccess: use proper PTE accessors for copying old memory
2026-07-20 14:47 [PATCH] s390/maccess: use proper PTE accessors for copying old memory Alexander Gordeev
@ 2026-07-20 14:51 ` sashiko-bot
2026-07-21 9:14 ` Heiko Carstens
2026-07-21 10:28 ` Vasily Gorbik
2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-07-20 14:51 UTC (permalink / raw)
To: Alexander Gordeev
Cc: Heiko Carstens, Alexander Gordeev, Vasily Gorbik, linux-s390
> Follow the pattern established by commit c33c794828f2 ("mm:
> ptep_get() conversion") and use proper PTE accessors instead
> of a direct pointer dereference in memcpy_real_iter().
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260720144734.1003497-1-agordeev@linux.ibm.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] s390/maccess: use proper PTE accessors for copying old memory
2026-07-20 14:47 [PATCH] s390/maccess: use proper PTE accessors for copying old memory Alexander Gordeev
2026-07-20 14:51 ` sashiko-bot
@ 2026-07-21 9:14 ` Heiko Carstens
2026-07-21 10:28 ` Vasily Gorbik
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Carstens @ 2026-07-21 9:14 UTC (permalink / raw)
To: Alexander Gordeev
Cc: Vasily Gorbik, Gerald Schaefer, linux-s390, linux-kernel
On Mon, Jul 20, 2026 at 04:47:34PM +0200, Alexander Gordeev wrote:
> Follow the pattern established by commit c33c794828f2 ("mm:
> ptep_get() conversion") and use proper PTE accessors instead
> of a direct pointer dereference in memcpy_real_iter().
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
> arch/s390/mm/maccess.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch subject needs to be fixed. Upper case "Use".
Besides that:
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] s390/maccess: use proper PTE accessors for copying old memory
2026-07-20 14:47 [PATCH] s390/maccess: use proper PTE accessors for copying old memory Alexander Gordeev
2026-07-20 14:51 ` sashiko-bot
2026-07-21 9:14 ` Heiko Carstens
@ 2026-07-21 10:28 ` Vasily Gorbik
2 siblings, 0 replies; 4+ messages in thread
From: Vasily Gorbik @ 2026-07-21 10:28 UTC (permalink / raw)
To: Alexander Gordeev
Cc: Gerald Schaefer, Heiko Carstens, linux-s390, linux-kernel
On Mon, Jul 20, 2026 at 04:47:34PM +0200, Alexander Gordeev wrote:
> Follow the pattern established by commit c33c794828f2 ("mm:
> ptep_get() conversion") and use proper PTE accessors instead
> of a direct pointer dereference in memcpy_real_iter().
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
> arch/s390/mm/maccess.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-21 10:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-20 14:47 [PATCH] s390/maccess: use proper PTE accessors for copying old memory Alexander Gordeev
2026-07-20 14:51 ` sashiko-bot
2026-07-21 9:14 ` Heiko Carstens
2026-07-21 10:28 ` Vasily Gorbik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.