Re: [PATCH] media: rkvdec: Propagate platform_get_irq() errors

From: Detlev Casanova <detlev.casanova@collabora.com>
To: Narasimharao Vadlamudi <ahmisaranrao@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Hans Verkuil <hverkuil@kernel.org>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Narasimharao Vadlamudi <ahmisaranrao@gmail.com>
Subject: Re: [PATCH] media: rkvdec: Propagate platform_get_irq() errors
Date: Thu, 02 Jul 2026 13:57:54 -0400	[thread overview]
Message-ID: <u6-dHgmpTzmKPiphpyUkbA@collabora.com> (raw)
In-Reply-To: <20260701111203.62092-1-ahmisaranrao@gmail.com>

Hi Vadlamudi,

On Wednesday, July 1, 2026 7:12:03 a.m. Eastern Daylight Time Narasimharao 
Vadlamudi wrote:
> platform_get_irq() returns a positive IRQ number on success and a
> negative error code on failure. It no longer returns zero. The driver
> currently returns -ENXIO for all failures, which loses useful errors
> such as -EPROBE_DEFER.
> 
> Return the error from platform_get_irq() directly.
> 
> Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver")
> Signed-off-by: Narasimharao Vadlamudi <ahmisaranrao@gmail.com>
> ---
>  drivers/media/platform/rockchip/rkvdec/rkvdec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> b/drivers/media/platform/rockchip/rkvdec/rkvdec.c index
> 1d1e9bfef8e9..37683a6bb40f 100644
> --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> @@ -1818,8 +1818,8 @@ static int rkvdec_probe(struct platform_device *pdev)
>  	vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32));
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq <= 0)
> -		return -ENXIO;
> +	if (irq < 0)
> +		return irq;
> 
>  	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
>  					rkvdec_irq_handler, 
IRQF_ONESHOT,

Thank you for the patch ! And sorry for the HTML email before. So for the 
record:

Reviewed-by: Detlev Casanova <detlev.casanova@collabora.com>

--
Detlev.