* Re: [PATCH] Avoid namespace pollution in <asm/param.h> [not found] <200601021702.k02H2mLh015729@hera.kernel.org> @ 2006-01-02 18:13 ` Sam Ravnborg 2006-01-03 10:47 ` Dag-Erling Smørgrav 0 siblings, 1 reply; 2+ messages in thread From: Sam Ravnborg @ 2006-01-02 18:13 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: Linus Torvalds, Dag-Erling Sm?rgrav On Mon, Jan 02, 2006 at 09:02:48AM -0800, Linux Kernel Mailing List wrote: > tree f0d89e7d946a7ed9b57bb29e93bae4ce25d2cbc2 > parent f12f4d90308a22396ac87f6c3a7b2620589614c3 > author Dag-Erling Sm?rgrav <des@linpro.no> Mon, 02 Jan 2006 15:57:06 +0100 > committer Linus Torvalds <torvalds@g5.osdl.org> Tue, 03 Jan 2006 00:38:38 -0800 > > [PATCH] Avoid namespace pollution in <asm/param.h> > > In commit 3D59121003721a8fad11ee72e646fd9d3076b5679c, the x86 and x86-64 > <asm/param.h> was changed to include <linux/config.h> for the > configurable timer frequency. config.h is always implicit included using -include option to gcc, so the > --- a/include/asm-i386/param.h > +++ b/include/asm-i386/param.h > @@ -1,9 +1,8 @@ > -#include <linux/config.h> is redundant and the correct patch would be to get rid of it. Same goes for: > --- a/include/asm-x86_64/param.h > +++ b/include/asm-x86_64/param.h > @@ -1,9 +1,8 @@ > -#include <linux/config.h> Sam ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Avoid namespace pollution in <asm/param.h> 2006-01-02 18:13 ` [PATCH] Avoid namespace pollution in <asm/param.h> Sam Ravnborg @ 2006-01-03 10:47 ` Dag-Erling Smørgrav 0 siblings, 0 replies; 2+ messages in thread From: Dag-Erling Smørgrav @ 2006-01-03 10:47 UTC (permalink / raw) To: Sam Ravnborg; +Cc: Linux Kernel Mailing List, Linus Torvalds Sam Ravnborg <sam@ravnborg.org> writes: > config.h is always implicit included using -include option to gcc, > so the #include <linux/config.h> is redundant and the correct patch > would be to get rid of it. In that case, you have your work cut out for you: des@xps ~/src/linux-2.6.14.5% grep -r linux/config.h . | wc -l 3777 This is likely to have a significant impact on compilation time... DES -- Dag-Erling Smørgrav - des@linpro.no ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-03 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200601021702.k02H2mLh015729@hera.kernel.org>
2006-01-02 18:13 ` [PATCH] Avoid namespace pollution in <asm/param.h> Sam Ravnborg
2006-01-03 10:47 ` Dag-Erling Smørgrav
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.