From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Greg Jacobson <coder5000@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v3] push: Enhance unspecified push default warning
Date: Thu, 07 Nov 2013 19:51:14 +0100 [thread overview]
Message-ID: <vpqtxfo2ggt.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqqr4as5bbh.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 07 Nov 2013 10:14:10 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Actually, to me, I found the "two sentences" the worst part in the
> original. It made it sound as if the default will be switching to
> 'upstream', and all readers need to read the second sentence that
> clarifies that it is not the case, in a somewhat round-about
> way---"will only succeed if" invites "and otherwise...?"
To me, this is not an issue given the audience (people too lazy to read
the docs): for them, current == simple == upstream modulo details
they're not interested about. The safety measure of "simple" is actually
here to make sure nothing wrong happens if they make the confusion.
But that's just a preference, I'm OK with your other proposal too.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-11-07 18:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 14:20 [PATCH v3] push: Enhance unspecified push default warning Greg Jacobson
2013-11-03 13:35 ` Greg Jacobson
2013-11-04 18:32 ` Junio C Hamano
2013-11-05 10:16 ` Matthieu Moy
2013-11-05 10:16 ` Matthieu Moy
2013-11-06 19:01 ` Junio C Hamano
2013-11-06 20:10 ` Junio C Hamano
2013-11-06 22:55 ` Junio C Hamano
2013-11-06 21:49 ` Matthieu Moy
2013-11-06 23:45 ` Jonathan Nieder
2013-11-07 10:52 ` Matthieu Moy
2013-11-07 18:14 ` Junio C Hamano
2013-11-07 18:51 ` Matthieu Moy [this message]
2013-11-08 18:02 ` Junio C Hamano
2013-11-08 18:56 ` Junio C Hamano
2013-11-08 22:39 ` Marc Branchaud
2013-11-11 17:02 ` Junio C Hamano
2013-11-11 17:03 ` Jonathan Nieder
2013-11-11 17:17 ` Marc Branchaud
2013-11-11 21:12 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqtxfo2ggt.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=coder5000@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.