All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	Greg Jacobson <coder5000@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v3] push: Enhance unspecified push default warning
Date: Fri, 08 Nov 2013 10:02:43 -0800	[thread overview]
Message-ID: <xmqqli0yojp8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqtxfo8ow4.fsf@anie.imag.fr> (Matthieu Moy's message of "Thu, 07 Nov 2013 11:52:43 +0100")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> 	When push.default is set to 'matching', git will push local branches
>> 	to remote branches that already exist with the same (matching) name.
>
> Yes, that's better than the original patch (and remains two lines).
> ...
>
>> 	In Git 2.0, git will default to a more conservative 'simple' behavior
>> 	that only pushes the current branch.
>
> That's an option too, but I think mentionning "git pull" was a good
> idea.

OK, I'll tentatively update the draft to read like this, redo the
endgame patch on top and requeue.

 builtin/push.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/builtin/push.c b/builtin/push.c
index 5393e28..27c5754 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -174,14 +174,12 @@ N_("push.default is unset; its implicit value is changing in\n"
    "\n"
    "  git config --global push.default simple\n"
    "\n"
-   "When push.default is set to 'matching', git will push all local branches\n"
-   "to the remote branches with the same (matching) name.  This will no\n"
-   "longer be the default in Git 2.0 because a branch could be\n"
-   "unintentionally pushed to a remote.\n"
+   "When push.default is set to 'matching', git will push local branches\n"
+   "to the remote branches that already exist with the same name.\n"
    "\n"
-   "In Git 2.0 the new push.default of 'simple' will push only the current\n"
-   "branch to the same remote branch used by git pull.   A push will\n"
-   "only succeed if the remote and local branches have the same name.\n"
+   "In Git 2.0, Git will default to the more conservative 'simple'\n"
+   "behavior that only pushes the current branch to the corresponding\n"
+   "remote branch used by 'git pull' to update the current branch from.\n"
    "\n"
    "See 'git help config' and search for 'push.default' for further information.\n"
    "(the 'simple' mode was introduced in Git 1.7.11. Use the similar mode\n"

  parent reply	other threads:[~2013-11-08 18:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 14:20 [PATCH v3] push: Enhance unspecified push default warning Greg Jacobson
2013-11-03 13:35 ` Greg Jacobson
2013-11-04 18:32   ` Junio C Hamano
2013-11-05 10:16     ` Matthieu Moy
2013-11-05 10:16     ` Matthieu Moy
2013-11-06 19:01       ` Junio C Hamano
2013-11-06 20:10         ` Junio C Hamano
2013-11-06 22:55           ` Junio C Hamano
2013-11-06 21:49         ` Matthieu Moy
2013-11-06 23:45           ` Jonathan Nieder
2013-11-07 10:52             ` Matthieu Moy
2013-11-07 18:14               ` Junio C Hamano
2013-11-07 18:51                 ` Matthieu Moy
2013-11-08 18:02               ` Junio C Hamano [this message]
2013-11-08 18:56                 ` Junio C Hamano
2013-11-08 22:39                 ` Marc Branchaud
2013-11-11 17:02                   ` Junio C Hamano
2013-11-11 17:03                     ` Jonathan Nieder
2013-11-11 17:17                     ` Marc Branchaud
2013-11-11 21:12                     ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqli0yojp8.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=coder5000@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.