From: Alberto Garcia <berto@igalia.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers
Date: Mon, 16 Nov 2015 09:28:21 +0100 [thread overview]
Message-ID: <w51vb92pcuy.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20151116034644.GD9498@stefanha-x1.localdomain>
On Mon 16 Nov 2015 04:46:44 AM CET, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> early_err:
>> qemu_opts_del(opts);
>> + QDECREF(interval_dict);
>> + QDECREF(interval_list);
>
> There is a codepath that reaches here without initializing interval_dict
> or interval_list:
>
> qemu_opts_absorb_qdict(opts, bs_opts, &error);
> if (error) {
> error_propagate(errp, error);
> goto early_err;
> }
You're right, I'll send a new version ASAP.
Berto
prev parent reply other threads:[~2015-11-16 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 13:17 [Qemu-devel] [PATCH] block: make 'stats-intervals' a list of integers Alberto Garcia
2015-11-11 15:32 ` [Qemu-devel] [PATCH for-2.5] " Eric Blake
2015-11-11 15:38 ` Alberto Garcia
2015-11-13 10:15 ` [Qemu-devel] [Qemu-block] [PATCH] " Stefan Hajnoczi
2015-11-13 10:50 ` Alberto Garcia
2015-11-16 3:47 ` Stefan Hajnoczi
2015-11-16 3:46 ` Stefan Hajnoczi
2015-11-16 8:28 ` Alberto Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51vb92pcuy.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.