From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Kiran Kella <kiran.kella@broadcom.com>,
willemb@google.com
Cc: davem@davemloft.net, edumazet@google.com,
daniel.zahka@gmail.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
jayakrishnan.udayavarma@broadcom.com,
ajit.khaparde@broadcom.com, akhilesh.samineni@broadcom.com
Subject: Re: [net-next, v3 1/2] psp: Support for transmit on logical device when the underlying transport device supports PSP.
Date: Sat, 28 Feb 2026 14:46:28 -0500 [thread overview]
Message-ID: <willemdebruijn.kernel.1c3d7105f1c48@gmail.com> (raw)
In-Reply-To: <20260228100449.19f6ef13@kernel.org>
Jakub Kicinski wrote:
> On Thu, 26 Feb 2026 10:46:53 -0800 Kiran Kella wrote:
> > This is achieved by propagating the psp_dev from the lower device
> > to the upper devices in the device stack via a netdevice notifier.
> > The lowest device owns the psp_dev pointer while the upper devices
> > just borrow the pointer. When the lower device is unlinked, the
> > borrowed pointer is cleared in the upper device.
> > Assumption being that psp_dev is set on the lowest device before
> > any upper devices are stacked on that lowest device.
>
> As I mentioned in the other thread I'd like to establish some clear
> expectation on where psd propagates automatically and where it doesn't.
> I don't want to see a stream of patches that say "fix propagating PSP
> onto X upper". And conversely report saying "PSP got propagated but
> it doesn't actually work" (macvlan in bridge mode etc).
>
> Hence my preference was to require the user who created the device
> to propagate PSP. Willem, WDYT?
Can you give a bit more detail what you have in mind?
An explicit user (netlink) API to associate a psp_dev with a
net_device?
next prev parent reply other threads:[~2026-02-28 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 18:46 [net-next, v3 0/2] psp: Support PSP Tx on logical devices like VLAN Kiran Kella
2026-02-26 18:46 ` [net-next, v3 1/2] psp: Support for transmit on logical device when the underlying transport device supports PSP Kiran Kella
2026-02-28 18:04 ` Jakub Kicinski
2026-02-28 19:46 ` Willem de Bruijn [this message]
2026-02-28 20:10 ` Jakub Kicinski
2026-02-28 20:30 ` Willem de Bruijn
2026-03-02 7:42 ` Kiran Kella
2026-02-26 18:46 ` [net-next, v3 2/2] selftests: drv-net: psp: add test for VLAN sub-interface Kiran Kella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.1c3d7105f1c48@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akhilesh.samineni@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jayakrishnan.udayavarma@broadcom.com \
--cc=kiran.kella@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.