From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, horms@kernel.org, petrm@nvidia.com,
willemb@google.com, daniel@iogearbox.net, fw@strlen.de,
ishaangandhi@gmail.com, rbonica@juniper.net,
tom@herbertland.com
Subject: Re: [PATCH net-next 0/3] icmp: Add RFC 5837 support
Date: Thu, 23 Oct 2025 09:39:49 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.e817f4414e22@gmail.com> (raw)
In-Reply-To: <410cd787-0085-4409-97c1-2019a7baab8b@kernel.org>
David Ahern wrote:
> On 10/22/25 12:53 AM, Ido Schimmel wrote:
> > Testing
> > =======
> >
> > The existing traceroute selftest is extended to test that ICMP
> > extensions are reported correctly when enabled. Both address families
> > are tested and with different packet sizes in order to make sure that
> > trimming / padding works correctly.
> >
>
> For the set:
> Reviewed-by: David Ahern <dsahern@kernel.org>
Same
Reviewed-by: Willem de Bruijn <willemb@google.com>
Based on answers to my questions no changes strictly needed.
prev parent reply other threads:[~2025-10-23 13:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 6:53 [PATCH net-next 0/3] icmp: Add RFC 5837 support Ido Schimmel
2025-10-22 6:53 ` [PATCH net-next 1/3] ipv4: " Ido Schimmel
2025-10-22 22:00 ` Willem de Bruijn
2025-10-23 8:35 ` Ido Schimmel
2025-10-22 6:53 ` [PATCH net-next 2/3] ipv6: " Ido Schimmel
2025-10-22 6:53 ` [PATCH net-next 3/3] selftests: traceroute: Add ICMP extensions tests Ido Schimmel
2025-10-22 22:12 ` Willem de Bruijn
2025-10-23 9:09 ` Ido Schimmel
2025-10-23 15:39 ` Ido Schimmel
2025-10-23 21:25 ` Willem de Bruijn
2025-10-22 13:26 ` [PATCH net-next 0/3] icmp: Add RFC 5837 support Jakub Kicinski
2025-10-22 13:58 ` Ido Schimmel
2025-10-22 15:10 ` Jakub Kicinski
2025-10-22 15:35 ` Ido Schimmel
2025-10-23 0:38 ` Jakub Kicinski
2025-10-24 1:48 ` Jakub Kicinski
2025-10-24 14:50 ` Ido Schimmel
2025-10-24 15:04 ` Jakub Kicinski
2025-10-22 17:29 ` David Ahern
2025-10-23 11:19 ` Ido Schimmel
2025-10-23 13:39 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.e817f4414e22@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=ishaangandhi@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=rbonica@juniper.net \
--cc=tom@herbertland.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.