* [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error
@ 2015-07-26 7:40 Joglekar, Tejas (T.)
2015-07-26 13:00 ` Jes Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Joglekar, Tejas (T.) @ 2015-07-26 7:40 UTC (permalink / raw)
To: Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com,
gregkh@linuxfoundation.org
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
From: Joglekar Tejas <tjogleka@visteon.com>
This patch fixes the error given by checkpatch.pl
Signed-off-by: Joglekar Tejas <tjogleka@visteon.com>
---
drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c
index 29a29d9..48b7723 100644
--- a/drivers/staging/rtl8723au/core/rtw_sreset.c
+++ b/drivers/staging/rtl8723au/core/rtw_sreset.c
@@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter)
/* pairwise key */
rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true);
/* group key */
- rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
+ rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
}
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error
2015-07-26 7:40 [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error Joglekar, Tejas (T.)
@ 2015-07-26 13:00 ` Jes Sorensen
2015-07-26 16:36 ` Joglekar, Tejas (T.)
0 siblings, 1 reply; 3+ messages in thread
From: Jes Sorensen @ 2015-07-26 13:00 UTC (permalink / raw)
To: Joglekar, Tejas (T.)
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
"Joglekar, Tejas (T.)" <tjogleka@visteon.com> writes:
> From: Joglekar Tejas <tjogleka@visteon.com>
>
> This patch fixes the error given by checkpatch.pl
>
> Signed-off-by: Joglekar Tejas <tjogleka@visteon.com>
> ---
> drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c
> index 29a29d9..48b7723 100644
> --- a/drivers/staging/rtl8723au/core/rtw_sreset.c
> +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c
> @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter)
> /* pairwise key */
> rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true);
> /* group key */
> - rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> + rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> }
> }
> }
NAK!
If you are 'fixing' checkpatch 'errors', do it properly and break down
the line and solve the 80 character limit 'error' as well.
Jes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error
2015-07-26 13:00 ` Jes Sorensen
@ 2015-07-26 16:36 ` Joglekar, Tejas (T.)
0 siblings, 0 replies; 3+ messages in thread
From: Joglekar, Tejas (T.) @ 2015-07-26 16:36 UTC (permalink / raw)
To: Jes Sorensen
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Sun, Jul 26, 2015 at 09:00:23AM -0400, Jes Sorensen wrote:
> "Joglekar, Tejas (T.)" <tjogleka@visteon.com> writes:
> > From: Joglekar Tejas <tjogleka@visteon.com>
> >
> > This patch fixes the error given by checkpatch.pl
> >
> > Signed-off-by: Joglekar Tejas <tjogleka@visteon.com>
> > ---
> > drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c
> > index 29a29d9..48b7723 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_sreset.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c
> > @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter)
> > /* pairwise key */
> > rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true);
> > /* group key */
> > - rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> > + rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> > }
> > }
> > }
>
> NAK!
>
> If you are 'fixing' checkpatch 'errors', do it properly and break down
> the line and solve the 80 character limit 'error' as well.
>
> Jes
Jes ,
Sure, I will break down the line, and remove the 80 character limit issue , before resending the patch.
Thanks & Regards,
Tejas Joglekar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-26 16:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-26 7:40 [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error Joglekar, Tejas (T.)
2015-07-26 13:00 ` Jes Sorensen
2015-07-26 16:36 ` Joglekar, Tejas (T.)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.