All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated
Date: Tue, 10 Nov 2015 17:06:31 +0100	[thread overview]
Message-ID: <xa1t8u65g7p4.fsf@mina86.com> (raw)
In-Reply-To: <1447053861-28824-2-git-send-email-iamjoonsoo.kim@lge.com>

On Mon, Nov 09 2015, Joonsoo Kim wrote:
> cma allocation should be guranteeded to succeed, but, sometimes,
> it could be failed in current implementation. To track down
> the problem, we need to know which page is problematic and
> this new tracepoint will report it.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

I’m not really familiar with tracing framework but other then that:

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  include/trace/events/cma.h | 26 ++++++++++++++++++++++++++
>  mm/page_isolation.c        |  5 +++++
>  2 files changed, 31 insertions(+)

-- 
Best regards,                                            _     _
.o. | Liege of Serenely Enlightened Majesty of         o' \,=./ `o
..o | Computer Science,  ミハウ “mina86” ナザレヴイツ  (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>-----ooO--(_)--Ooo--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Michal Nazarewicz <mina86@mina86.com>
To: Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated
Date: Tue, 10 Nov 2015 17:06:31 +0100	[thread overview]
Message-ID: <xa1t8u65g7p4.fsf@mina86.com> (raw)
In-Reply-To: <1447053861-28824-2-git-send-email-iamjoonsoo.kim@lge.com>

On Mon, Nov 09 2015, Joonsoo Kim wrote:
> cma allocation should be guranteeded to succeed, but, sometimes,
> it could be failed in current implementation. To track down
> the problem, we need to know which page is problematic and
> this new tracepoint will report it.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

I’m not really familiar with tracing framework but other then that:

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  include/trace/events/cma.h | 26 ++++++++++++++++++++++++++
>  mm/page_isolation.c        |  5 +++++
>  2 files changed, 31 insertions(+)

-- 
Best regards,                                            _     _
.o. | Liege of Serenely Enlightened Majesty of         o' \,=./ `o
..o | Computer Science,  ミハウ “mina86” ナザレヴイツ  (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>-----ooO--(_)--Ooo--

  parent reply	other threads:[~2015-11-10 16:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09  7:24 [PATCH 1/3] mm/page_isolation: return last tested pfn rather than failure indicator Joonsoo Kim
2015-11-09  7:24 ` Joonsoo Kim
2015-11-09  7:24 ` [PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated Joonsoo Kim
2015-11-09  7:24   ` Joonsoo Kim
2015-11-09 22:59   ` David Rientjes
2015-11-09 22:59     ` David Rientjes
2015-11-10  0:22     ` Joonsoo Kim
2015-11-10  0:22       ` Joonsoo Kim
2015-11-10 16:06   ` Michal Nazarewicz [this message]
2015-11-10 16:06     ` Michal Nazarewicz
2015-11-09  7:24 ` [PATCH 3/3] mm/cma: always check which page cause allocation failure Joonsoo Kim
2015-11-09  7:24   ` Joonsoo Kim
2015-11-09 22:55 ` [PATCH 1/3] mm/page_isolation: return last tested pfn rather than failure indicator David Rientjes
2015-11-09 22:55   ` David Rientjes
2015-11-10 16:05 ` Michal Nazarewicz
2015-11-10 16:05   ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1t8u65g7p4.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.