From: Michal Nazarewicz <mina86@mina86.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] mm: cma: Ensure that reservations never cross the low/high mem boundary
Date: Fri, 24 Oct 2014 16:26:58 +0000 [thread overview]
Message-ID: <xa1toat13031.fsf@mina86.com> (raw)
In-Reply-To: <1414145922-26042-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Fri, Oct 24 2014, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote:
> Commit 95b0e655f914 ("ARM: mm: don't limit default CMA region only to
> low memory") extended CMA memory reservation to allow usage of high
> memory. It relied on commit f7426b983a6a ("mm: cma: adjust address limit
> to avoid hitting low/high memory boundary") to ensure that the reserved
> block never crossed the low/high memory boundary. While the
> implementation correctly lowered the limit, it failed to consider the
> case where the base..limit range crossed the low/high memory boundary
> with enough space on each side to reserve the requested size on either
> low or high memory.
>
> Rework the base and limit adjustment to fix the problem. The function
> now starts by rejecting the reservation altogether for fixed
> reservations that cross the boundary, tries to reserve from high memory
> first and then falls back to low memory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
WARNING: multiple messages have this Message-ID (diff)
From: mina86@mina86.com (Michal Nazarewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] mm: cma: Ensure that reservations never cross the low/high mem boundary
Date: Fri, 24 Oct 2014 18:26:58 +0200 [thread overview]
Message-ID: <xa1toat13031.fsf@mina86.com> (raw)
In-Reply-To: <1414145922-26042-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Fri, Oct 24 2014, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote:
> Commit 95b0e655f914 ("ARM: mm: don't limit default CMA region only to
> low memory") extended CMA memory reservation to allow usage of high
> memory. It relied on commit f7426b983a6a ("mm: cma: adjust address limit
> to avoid hitting low/high memory boundary") to ensure that the reserved
> block never crossed the low/high memory boundary. While the
> implementation correctly lowered the limit, it failed to consider the
> case where the base..limit range crossed the low/high memory boundary
> with enough space on each side to reserve the requested size on either
> low or high memory.
>
> Rework the base and limit adjustment to fix the problem. The function
> now starts by rejecting the reservation altogether for fixed
> reservations that cross the boundary, tries to reserve from high memory
> first and then falls back to low memory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Nazarewicz <mina86@mina86.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Weijie Yang <weijie.yang.kh@gmail.com>
Subject: Re: [PATCH v2 3/4] mm: cma: Ensure that reservations never cross the low/high mem boundary
Date: Fri, 24 Oct 2014 18:26:58 +0200 [thread overview]
Message-ID: <xa1toat13031.fsf@mina86.com> (raw)
In-Reply-To: <1414145922-26042-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Fri, Oct 24 2014, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote:
> Commit 95b0e655f914 ("ARM: mm: don't limit default CMA region only to
> low memory") extended CMA memory reservation to allow usage of high
> memory. It relied on commit f7426b983a6a ("mm: cma: adjust address limit
> to avoid hitting low/high memory boundary") to ensure that the reserved
> block never crossed the low/high memory boundary. While the
> implementation correctly lowered the limit, it failed to consider the
> case where the base..limit range crossed the low/high memory boundary
> with enough space on each side to reserve the requested size on either
> low or high memory.
>
> Rework the base and limit adjustment to fix the problem. The function
> now starts by rejecting the reservation altogether for fixed
> reservations that cross the boundary, tries to reserve from high memory
> first and then falls back to low memory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Nazarewicz <mina86@mina86.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Weijie Yang <weijie.yang.kh@gmail.com>
Subject: Re: [PATCH v2 3/4] mm: cma: Ensure that reservations never cross the low/high mem boundary
Date: Fri, 24 Oct 2014 18:26:58 +0200 [thread overview]
Message-ID: <xa1toat13031.fsf@mina86.com> (raw)
In-Reply-To: <1414145922-26042-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Fri, Oct 24 2014, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote:
> Commit 95b0e655f914 ("ARM: mm: don't limit default CMA region only to
> low memory") extended CMA memory reservation to allow usage of high
> memory. It relied on commit f7426b983a6a ("mm: cma: adjust address limit
> to avoid hitting low/high memory boundary") to ensure that the reserved
> block never crossed the low/high memory boundary. While the
> implementation correctly lowered the limit, it failed to consider the
> case where the base..limit range crossed the low/high memory boundary
> with enough space on each side to reserve the requested size on either
> low or high memory.
>
> Rework the base and limit adjustment to fix the problem. The function
> now starts by rejecting the reservation altogether for fixed
> reservations that cross the boundary, tries to reserve from high memory
> first and then falls back to low memory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
next prev parent reply other threads:[~2014-10-24 16:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 10:18 [PATCH v2 0/4] Low/high memory CMA reservation fixes Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` [PATCH v2 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` [PATCH v2 2/4] mm: cma: Always consider a 0 base address reservation as dynamic Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` [PATCH v2 3/4] mm: cma: Ensure that reservations never cross the low/high mem boundary Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 16:26 ` Michal Nazarewicz [this message]
2014-10-24 16:26 ` Michal Nazarewicz
2014-10-24 16:26 ` Michal Nazarewicz
2014-10-24 16:26 ` Michal Nazarewicz
2014-10-26 12:43 ` Laurent Pinchart
2014-10-26 12:43 ` Laurent Pinchart
2014-10-26 12:43 ` Laurent Pinchart
2014-10-26 12:43 ` Laurent Pinchart
2014-10-27 7:44 ` Joonsoo Kim
2014-10-27 7:44 ` Joonsoo Kim
2014-10-27 7:44 ` Joonsoo Kim
2014-10-27 7:44 ` Joonsoo Kim
2014-10-24 10:18 ` [PATCH v2 4/4] mm: cma: Use %pa to print physical addresses Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-24 10:18 ` Laurent Pinchart
2014-10-27 12:13 ` [PATCH v2 0/4] Low/high memory CMA reservation fixes Marek Szyprowski
2014-10-27 12:13 ` Marek Szyprowski
2014-10-27 12:13 ` Marek Szyprowski
2014-10-27 12:13 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1toat13031.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.