All of lore.kernel.org
 help / color / mirror / Atom feed
From: mina86@mina86.com (Michal Nazarewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dma-buf: add helpers for attacher dma-parms
Date: Mon, 06 Aug 2012 13:58:32 +0200	[thread overview]
Message-ID: <xa1tobmoxmdz.fsf@mina86.com> (raw)
In-Reply-To: <501F9C8E.4080002@samsung.com>


Tomasz Stanislawski <t.stanislaws@samsung.com> writes:
> I recommend to change the semantics for unlimited number of segments
> from 'value 0' to:
>
> #define DMA_SEGMENTS_COUNT_UNLIMITED ((unsigned long)INT_MAX)
>
> Using INT_MAX will allow using safe conversions between signed and
> unsigned integers.

LONG_MAX seems cleaner regardless.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Micha? ?mina86? Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120806/977107ce/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Michal Nazarewicz <mina86@mina86.com>
To: Tomasz Stanislawski <t.stanislaws@samsung.com>,
	Rob Clark <rob.clark@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
	linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org, patches@linaro.org,
	linux@arm.linux.org.uk, arnd@arndb.de, jesse.barker@linaro.org,
	m.szyprowski@samsung.com, daniel@ffwll.ch, sumit.semwal@ti.com,
	maarten.lankhorst@canonical.com, Rob Clark <rob@ti.com>
Subject: Re: [PATCH 2/2] dma-buf: add helpers for attacher dma-parms
Date: Mon, 06 Aug 2012 13:58:32 +0200	[thread overview]
Message-ID: <xa1tobmoxmdz.fsf@mina86.com> (raw)
In-Reply-To: <501F9C8E.4080002@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]


Tomasz Stanislawski <t.stanislaws@samsung.com> writes:
> I recommend to change the semantics for unlimited number of segments
> from 'value 0' to:
>
> #define DMA_SEGMENTS_COUNT_UNLIMITED ((unsigned long)INT_MAX)
>
> Using INT_MAX will allow using safe conversions between signed and
> unsigned integers.

LONG_MAX seems cleaner regardless.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]

  reply	other threads:[~2012-08-06 11:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 16:23 [PATCH 0/2] dma-parms and helpers for dma-buf Rob Clark
2012-07-19 16:23 ` Rob Clark
2012-07-19 16:23 ` Rob Clark
2012-07-19 16:23 ` [PATCH 1/2] device: add dma_params->max_segment_count Rob Clark
2012-07-19 16:23   ` Rob Clark
2012-07-19 16:23   ` Rob Clark
2012-07-20  6:20   ` Marek Szyprowski
2012-07-20  6:20     ` Marek Szyprowski
2012-07-20  6:20     ` Marek Szyprowski
2012-07-19 16:23 ` [PATCH 2/2] dma-buf: add helpers for attacher dma-parms Rob Clark
2012-07-19 16:23   ` Rob Clark
2012-07-19 16:23   ` Rob Clark
2012-07-20 16:39   ` Rob Clark
2012-07-20 16:39     ` Rob Clark
2012-07-20 16:39     ` Rob Clark
2012-08-06  6:37     ` Semwal, Sumit
2012-08-06  6:37       ` Semwal, Sumit
2012-08-06  6:37       ` Semwal, Sumit
2012-08-06 10:29   ` Tomasz Stanislawski
2012-08-06 10:29     ` Tomasz Stanislawski
2012-08-06 10:29     ` Tomasz Stanislawski
2012-08-06 11:58     ` Michal Nazarewicz [this message]
2012-08-06 11:58       ` Michal Nazarewicz
2012-08-06 12:42       ` Tomasz Stanislawski
2012-08-06 12:42         ` Tomasz Stanislawski
2012-08-06 12:42         ` Tomasz Stanislawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1tobmoxmdz.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.