Re: [PATCH v5 1/5] fastboot: factor out the USB session runner

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

On Fri, Sep 11, 2026 at 15:33, Carlo Caione <ccaione@baylibre.com> wrote:

> On Fri, Sep 11, 2026 at 14:34:47 +0100, Mattijs Korpershoek wrote:
>> Hi Carlo,
>> 
>> Thank you for the patch.
>> 
>> compared with v3, v5 introduced some new changes which I don't
>> understand.
>> 
>> Please see below.
>
> Yeah, sorry about that. I received an off-list review so the changes are
> probably result of fixing those comments.

When possible, can we please try to avoid off-list reviews (or do them before
sending things out publicly) ?
It makes following along various versions for series harder (at least to
me)

>
> [...]
>> > --- /dev/null
>> > +++ b/drivers/fastboot/fb_usb.c
>> > @@ -0,0 +1,66 @@
>> > +// SPDX-License-Identifier: GPL-2.0-or-later
>> 
>> Why is this GPL-2.0-or-later? In v3 it was GPL-2.0+ which is what's
>> present in cmd/fastboot.c
>
> There was a suggestion to move to GPL-2.0-or-later because GPL-2.0+ is
> currently deprecated see https://spdx.org/licenses/GPL-2.0+.html

Ah, I was not aware that GPL-2.0+ was deprecated. Thanks for letting me know.

I see it's still widely used in the U-Boot sources:

$ git grep --count GPL-2.0+ | wc -l
14298

$ git grep --count GPL-2.0-or-later | wc -l
2315

I agree that we should migrate to GPL-2.0-or-later but that's not in
scope for this series, in my opinion.
Therefore, can we please keep the (deprecated) GPL-2.0+ instead since we
are literally copying it over from cmd/fastboot.c ?

Thanks
Mattijs

>
>> > +/*
>> > + * Copyright 2026 BayLibre SAS
>> 
>> This was also not present in v3 and does not seem an appropriate
>> addition to me since we are just copying code around. Why should it have
>> a new copyright?
>
> Totally fair point, I'll remove this.
>
> Thanks!
>
> --
> Carlo Caione