From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Carlo Caione <ccaione@baylibre.com>,
u-boot@lists.u-boot-project.org,
GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>
Cc: "Suhrid Subramaniam" <Suhrid.Subramaniam@mediatek.com>,
"Macpaul Lin (林智斌)" <Macpaul.Lin@mediatek.com>,
"Pablo Sun (孫毓翔)" <pablo.sun@mediatek.com>,
"Arnaud Ferraris" <arnaud.ferraris@collabora.com>,
"Tom Rini" <trini@konsulko.com>, "Simon Glass" <sjg@chromium.org>,
"Sam Day" <me@samcday.com>,
"Quentin Schulz" <quentin.schulz@cherry.de>,
"Carlo Caione" <ccaione@baylibre.com>,
"David Lechner" <dlechner@baylibre.com>,
"Vitor Sato Eschholz" <vsatoes@baylibre.com>,
"Lukasz Majewski" <lukma@denx.de>,
"Marek Vasut" <marek.vasut+usb@mailbox.org>,
"Peng Fan" <peng.fan@nxp.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Julien Masson" <jmasson@baylibre.com>,
"Alexey Charkov" <alchark@gmail.com>,
"Adrian Freihofer" <adrian.freihofer@siemens.com>,
"Francois Berder" <fberder@outlook.fr>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
"Vincent Jardin" <vjardin@free.fr>,
"Peter Robinson" <pbrobinson@gmail.com>
Subject: Re: [PATCH v5 3/5] fastboot: make shared configuration checks phase-aware
Date: Fri, 11 Sep 2026 14:38:32 +0200 [thread overview]
Message-ID: <xhkdbcxuk3quv.fsf@mkorpers-koolstof.csb> (raw)
In-Reply-To: <20260906-ccaione-upstream-spl-fastboot-v5-3-023516e77321@baylibre.com>
Hi Carlo,
Thank you for the patch.
On Sun, Sep 06, 2026 at 22:02, Carlo Caione <ccaione@baylibre.com> wrote:
> Fastboot currently builds only for U-Boot proper, so its source and
> Makefile rules test CONFIG_FASTBOOT_* directly. The same checks would
> select U-Boot-proper options when these files are compiled for another
> phase, potentially compiling unavailable backends or using the wrong
> configuration values.
>
> Use CONFIG_IS_ENABLED(), CONFIG_VAL() and CONFIG_$(PHASE_) consistently
> for code and object selection. The empty phase prefix preserves the
> existing U-Boot-proper configuration and behavior while making the
> shared implementation safe to reuse from SPL.
>
> This also makes the Android boot-image condition phase-aware. Since SPL
> has no SPL_ANDROID_BOOT_IMAGE option, the existing flash:zimage path
> remains available only in U-Boot proper.
>
> Signed-off-by: Julien Masson <jmasson@baylibre.com>
> Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
next prev parent reply other threads:[~2026-09-11 12:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 20:01 [PATCH v5 0/5] Add fastboot to SPL Carlo Caione
2026-09-06 20:01 ` [PATCH v5 1/5] fastboot: factor out the USB session runner Carlo Caione
2026-09-09 20:31 ` David Lechner
2026-09-11 12:34 ` Mattijs Korpershoek
2026-09-11 13:33 ` Carlo Caione
2026-09-11 14:49 ` Mattijs Korpershoek
2026-09-06 20:02 ` [PATCH v5 2/5] fastboot: use the common handler for USB reboot Carlo Caione
2026-09-06 20:02 ` [PATCH v5 3/5] fastboot: make shared configuration checks phase-aware Carlo Caione
2026-09-11 12:38 ` Mattijs Korpershoek [this message]
2026-09-06 20:02 ` [PATCH v5 4/5] image: sparse: add phase-aware SPL support Carlo Caione
2026-09-06 20:02 ` [PATCH v5 5/5] fastboot: add " Carlo Caione
2026-09-09 21:16 ` David Lechner
2026-09-09 21:23 ` Carlo Caione
2026-09-09 21:57 ` David Lechner
2026-09-11 12:26 ` Mattijs Korpershoek
2026-09-11 13:30 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xhkdbcxuk3quv.fsf@mkorpers-koolstof.csb \
--to=mkorpershoek@kernel.org \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=Macpaul.Lin@mediatek.com \
--cc=Suhrid.Subramaniam@mediatek.com \
--cc=adrian.freihofer@siemens.com \
--cc=alchark@gmail.com \
--cc=arnaud.ferraris@collabora.com \
--cc=ccaione@baylibre.com \
--cc=dlechner@baylibre.com \
--cc=fberder@outlook.fr \
--cc=ilias.apalodimas@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=jmasson@baylibre.com \
--cc=lukma@denx.de \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marek.vasut+usb@mailbox.org \
--cc=me@samcday.com \
--cc=neil.armstrong@linaro.org \
--cc=pablo.sun@mediatek.com \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=vjardin@free.fr \
--cc=vsatoes@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.