From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>,
Josh Triplett <josh@joshtriplett.org>,
Thomas Rast <tr@thomasrast.ch>,
Michael Haggerty <mhagger@alum.mit.edu>,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <greg@kroah.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"
Date: Mon, 30 Dec 2013 09:19:55 -0800 [thread overview]
Message-ID: <xmqq1u0utfwk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131224063726.19560.61859.chriscool@tuxfamily.org> (Christian Couder's message of "Tue, 24 Dec 2013 07:37:25 +0100")
Christian Couder <chriscool@tuxfamily.org> writes:
> +# Do not remove trailing spaces below!
> +cat >complex_message_trailers <<'EOF'
> +Fixes:
> +Acked-by:
> +Reviewed-by:
> +Signed-off-by:
> +EOF
Just a hint. I think it is far safer and robust over time to do
something like this:
sed -e 's/ Z$/ /' <<-\EOF
Fixes: Z
Acked-by: Z
EOF
instead of a comment, which can warn human developers but does not
do anything to prevent their editors' auto-fix features from kicking
in.
next prev parent reply other threads:[~2013-12-30 17:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 6:37 [PATCH 0/9] Add interpret-trailers builtin Christian Couder
2013-12-24 6:37 ` [PATCH 1/9] Add data structures and basic functions for commit trailers Christian Couder
2013-12-24 6:37 ` [PATCH 2/9] trailer: process trailers from file and arguments Christian Couder
2013-12-24 6:37 ` [PATCH 3/9] trailer: read and process config information Christian Couder
2013-12-24 13:47 ` Christian Couder
2013-12-24 6:37 ` [PATCH 4/9] trailer: process command line trailer arguments Christian Couder
2013-12-24 6:37 ` [PATCH 5/9] strbuf: add strbuf_isspace() Christian Couder
2013-12-24 6:37 ` [PATCH 6/9] trailer: parse trailers from input file Christian Couder
2013-12-24 6:37 ` [PATCH 7/9] trailer: put all the processing together and print Christian Couder
2013-12-24 6:37 ` [PATCH 8/9] trailer: add interpret-trailers command Christian Couder
2013-12-24 6:37 ` [PATCH 9/9] trailer: add tests for "git interpret-trailers" Christian Couder
2013-12-30 17:19 ` Junio C Hamano [this message]
2013-12-30 20:20 ` Josh Triplett
2013-12-30 20:46 ` Junio C Hamano
2013-12-30 20:52 ` Josh Triplett
2013-12-30 21:05 ` Junio C Hamano
2013-12-30 22:27 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1u0utfwk.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=dan.carpenter@oracle.com \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
--cc=johan@herland.net \
--cc=josh@joshtriplett.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.