From: Junio C Hamano <gitster@pobox.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Christian Couder <chriscool@tuxfamily.org>,
git@vger.kernel.org, Johan Herland <johan@herland.net>,
Thomas Rast <tr@thomasrast.ch>,
Michael Haggerty <mhagger@alum.mit.edu>,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <greg@kroah.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"
Date: Mon, 30 Dec 2013 13:05:25 -0800 [thread overview]
Message-ID: <xmqqfvpaqcbu.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131230205234.GU27213@leaf> (Josh Triplett's message of "Mon, 30 Dec 2013 12:52:34 -0800")
Josh Triplett <josh@joshtriplett.org> writes:
>> - The "everybody will have a single SP at the end" may or may not
>> last forever;
>
> Trivially fixed if that ever changes, but given the nature of all of
> these, that seems unlikely.
Why? Because we encourage to write tests that are expected to find
breakages, some of these test vector lines may have to show a broken
line that lacks SP after label + colon.
>> - With your scheme, if you already had _one_ trailing SPs in the
>> input, it would be hard to spot in the source;
>
> Git makes them quite difficult to miss. :)
That is irrelevant, isn't it?
This is about protecting the source in the editor, before you run
"git show --whitespace=trailing-space", "git diff --check", etc.
next prev parent reply other threads:[~2013-12-30 21:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 6:37 [PATCH 0/9] Add interpret-trailers builtin Christian Couder
2013-12-24 6:37 ` [PATCH 1/9] Add data structures and basic functions for commit trailers Christian Couder
2013-12-24 6:37 ` [PATCH 2/9] trailer: process trailers from file and arguments Christian Couder
2013-12-24 6:37 ` [PATCH 3/9] trailer: read and process config information Christian Couder
2013-12-24 13:47 ` Christian Couder
2013-12-24 6:37 ` [PATCH 4/9] trailer: process command line trailer arguments Christian Couder
2013-12-24 6:37 ` [PATCH 5/9] strbuf: add strbuf_isspace() Christian Couder
2013-12-24 6:37 ` [PATCH 6/9] trailer: parse trailers from input file Christian Couder
2013-12-24 6:37 ` [PATCH 7/9] trailer: put all the processing together and print Christian Couder
2013-12-24 6:37 ` [PATCH 8/9] trailer: add interpret-trailers command Christian Couder
2013-12-24 6:37 ` [PATCH 9/9] trailer: add tests for "git interpret-trailers" Christian Couder
2013-12-30 17:19 ` Junio C Hamano
2013-12-30 20:20 ` Josh Triplett
2013-12-30 20:46 ` Junio C Hamano
2013-12-30 20:52 ` Josh Triplett
2013-12-30 21:05 ` Junio C Hamano [this message]
2013-12-30 22:27 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfvpaqcbu.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=dan.carpenter@oracle.com \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
--cc=johan@herland.net \
--cc=josh@joshtriplett.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.