From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Beat Bolli" <dev+git@drbeat.li>,
git@vger.kernel.org,
"Philippe Blain" <levraiphilippeblain@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] completion: use awk for filtering the config entries
Date: Mon, 19 Feb 2024 09:19:26 -0800 [thread overview]
Message-ID: <xmqq4je4e5i9.fsf@gitster.g> (raw)
In-Reply-To: <aa3e36a1-52d3-0c15-b70b-83c6664757f5@gmx.de> (Johannes Schindelin's message of "Sun, 18 Feb 2024 22:58:20 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> > Makes sense. I wonder if we can have some simple script sanity
>> > checker that catches things like this, e.g., catting a single file
>> > into pipe, grep appearing upstream of awk or sed, etc.
>>
>> Yes, there are quite a few cases of these in t/. I'm not sure if it's worth
>> the churn, though. At least it would make the tests faster on Windows...
>
> Thank you for caring about the speed on Windows!
Yup, that is why I asked ;-)
next prev parent reply other threads:[~2024-02-19 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 17:10 [PATCH] completion: use awk for filtering the config entries Beat Bolli
2024-02-16 17:35 ` Junio C Hamano
2024-02-16 18:29 ` Beat Bolli
2024-02-18 21:58 ` Johannes Schindelin
2024-02-19 17:19 ` Junio C Hamano [this message]
2024-02-16 18:47 ` Philippe Blain
2024-02-16 20:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4je4e5i9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.