From: Junio C Hamano <gitster@pobox.com>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Jeremiah Mahler <jmmahler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Documentation/technical/api-hashmap: Remove source highlighting
Date: Mon, 19 May 2014 10:09:12 -0700 [thread overview]
Message-ID: <xmqq4n0l3dc7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405172035160.44324@all-night-tool.MIT.EDU> (Anders Kaseorg's message of "Sat, 17 May 2014 20:50:35 -0400 (EDT)")
Anders Kaseorg <andersk@MIT.EDU> writes:
> Yes; when I noticed this failure, I asked Jonathan to add source-highlight
> as a build dependency in Debian (https://bugs.debian.org/745591). But
> then Ubuntu forked the packaging to revert this change
> (https://bugs.launchpad.net/bugs/1316810), because source-highlight in the
> community-supported universe repository is not allowed to be a build
> dependency ...
The reasoning and solution Ubuntu has sounds sensible *but* it also
soudns like it is incomplete. If Ubuntu does not want to use
highlight, it can apply a change like the patch in question as part
of their fork to make the end result consistent and they are failing
to do so. If the tooling do not use highlight, the source should
not require highlight, either. It is ultimately their bug.
It however *is* our business, as their upstream, to make it easier
for distros that want to use and distros that do not want to depend
on highlight, and aiming for a solution that relieves Ubuntu or any
other distros from needing to carry one more patch is a good thing.
How bad does the documentation look with the patch applied (I know
how bad it looks without source-highlight installed)? If it is not
too bad, then it sounds like a sensible solution to drop the
highlight markup unconditionally like the patch that started this
thread does, taking the "common denominator" approach. You seem to
agree, and I do not object, either.
> But I don’t that would be worth it just to make one page of the API
> documentation a little more colorful (and it sounds like you agree).
next prev parent reply other threads:[~2014-05-19 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 11:08 [PATCH] Documentation/technical/api-hashmap: Remove source highlighting Anders Kaseorg
2014-05-17 15:22 ` Jeremiah Mahler
2014-05-18 0:50 ` Anders Kaseorg
2014-05-19 17:09 ` Junio C Hamano [this message]
2014-05-19 23:40 ` Anders Kaseorg
2014-05-20 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4n0l3dc7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=jmmahler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.