All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Jeremiah Mahler <jmmahler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Documentation/technical/api-hashmap: Remove source highlighting
Date: Tue, 20 May 2014 10:31:29 -0700	[thread overview]
Message-ID: <xmqqiop01hn2.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405191839230.44324@all-night-tool.MIT.EDU> (Anders Kaseorg's message of "Mon, 19 May 2014 19:40:35 -0400 (EDT)")

Anders Kaseorg <andersk@MIT.EDU> writes:

>> How bad does the documentation look with the patch applied (I know how 
>> bad it looks without source-highlight installed)?  If it is not too bad, 
>> then it sounds like a sensible solution to drop the highlight markup 
>> unconditionally like the patch that started this thread does, taking the 
>> "common denominator" approach.  You seem to agree, and I do not object, 
>> either.
>
> Original version with syntax-highlight installed (pretty):
> http://web.mit.edu/andersk/Public/api-hashmap/old-highlight.html
>
> Original version with syntax-highlight missing (corrupted):
> http://web.mit.edu/andersk/Public/api-hashmap/old-no-highlight.html
>
> Patched version (boring but readable):
> http://web.mit.edu/andersk/Public/api-hashmap/patched.html

Thanks.  I've queued the patch for v2.0 and the comparison between
the first and the third clearly shows that it is the right thing to
do ;-).

      reply	other threads:[~2014-05-20 17:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-17 11:08 [PATCH] Documentation/technical/api-hashmap: Remove source highlighting Anders Kaseorg
2014-05-17 15:22 ` Jeremiah Mahler
2014-05-18  0:50   ` Anders Kaseorg
2014-05-19 17:09     ` Junio C Hamano
2014-05-19 23:40       ` Anders Kaseorg
2014-05-20 17:31         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqiop01hn2.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=andersk@MIT.EDU \
    --cc=git@vger.kernel.org \
    --cc=jmmahler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.