From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Maarten Bosmans <mkbosmans@gmail.com>,
git@vger.kernel.org, Teng Long <dyroneteng@gmail.com>,
Maarten Bosmans <maarten.bosmans@vortech.nl>
Subject: Re: [PATCH 1/4] notes: print note blob to stdout directly
Date: Tue, 13 Feb 2024 09:35:28 -0800 [thread overview]
Message-ID: <xmqq5xys6zdr.fsf@gitster.g> (raw)
In-Reply-To: <20240213080014.GB2225494@coredump.intra.peff.net> (Jeff King's message of "Tue, 13 Feb 2024 03:00:14 -0500")
Jeff King <peff@peff.net> writes:
> On Tue, Feb 06, 2024 at 09:52:38AM -0800, Junio C Hamano wrote:
>
>> > That is also a cool idea. That would probably use the functionality of
>> > the cat-file batch mode, right?
>>
>> Not really. I was hoping that "git show" that can take multiple
>> objects from its command line would directly be used, or with a new
>> option that gives a separator between these objects.
>
> How about:
>
> cat some_commit_ids |
> git show --stdin -s -z --format='%H%n%N'
Yeah, that is more in line with what I was hoping to see, instead of
invoking "git show %s" for a note object one by one.
Thanks.
Remind me if you can if we (1) had plans to allow non-blob objects
as notes, or (2) actively support to have non-text blob objects as
notes. I _think_ we do assume people may try to add non-text blob
as notes (while they accept that they cannot merge two such notes on
the same object), but I do not recall if we planned to allow them to
store trees and commits.
next prev parent reply other threads:[~2024-02-13 17:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 20:49 [PATCH 0/4] Speed up git-notes show Maarten Bosmans
2024-02-05 20:49 ` [PATCH 1/4] notes: print note blob to stdout directly Maarten Bosmans
2024-02-06 3:44 ` Junio C Hamano
2024-02-06 9:55 ` Maarten Bosmans
2024-02-06 17:52 ` Junio C Hamano
2024-02-13 8:00 ` Jeff King
2024-02-13 17:35 ` Junio C Hamano [this message]
2024-02-15 5:26 ` Jeff King
2024-02-16 6:25 ` Junio C Hamano
2024-02-17 5:16 ` Jeff King
2024-02-17 5:56 ` Junio C Hamano
2024-02-17 6:09 ` Jeff King
2024-02-15 7:46 ` Maarten Bosmans
2024-02-15 15:04 ` Jeff King
2024-02-17 12:45 ` Maarten Bosmans
2024-02-20 1:51 ` Jeff King
2024-02-15 7:41 ` Maarten Bosmans
2024-02-06 13:55 ` Kristoffer Haugsbakk
2024-02-05 20:49 ` [PATCH 2/4] notes: use exisisting function stream_blob_to_fd Maarten Bosmans
2024-02-05 22:00 ` Eric Sunshine
2024-02-05 20:49 ` [PATCH 3/4] notes: do not clean up right before calling die() Maarten Bosmans
2024-02-05 20:49 ` [PATCH 4/4] notes: use strbuf_attach to take ownership of the object contents Maarten Bosmans
2024-02-06 7:08 ` [PATCH 0/4] Speed up git-notes show Kristoffer Haugsbakk
2024-02-06 8:51 ` Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 0/5] " Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 1/5] log: Move show_blob_object() to log.c Maarten Bosmans
2024-02-20 1:22 ` Junio C Hamano
2024-02-20 1:59 ` Jeff King
2024-02-20 3:03 ` Junio C Hamano
2024-02-20 11:40 ` Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 2/5] notes: avoid launching a child process to show a note blob Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 3/5] notes: use existing function stream_blob_to_fd Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 4/5] notes: do not clean up right before calling die() Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 5/5] notes: use strbuf_attach to take ownership of the object contents Maarten Bosmans
2024-02-20 2:12 ` Jeff King
2024-02-20 7:42 ` Maarten Bosmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xys6zdr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=maarten.bosmans@vortech.nl \
--cc=mkbosmans@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.