From: Junio C Hamano <gitster@pobox.com>
To: Maarten Bosmans <mkbosmans@gmail.com>
Cc: git@vger.kernel.org, Maarten Bosmans <maarten.bosmans@vortech.nl>
Subject: Re: [PATCH v2 1/5] log: Move show_blob_object() to log.c
Date: Mon, 19 Feb 2024 17:22:44 -0800 [thread overview]
Message-ID: <xmqqjzn0x72z.fsf@gitster.g> (raw)
In-Reply-To: <20240218195938.6253-2-maarten.bosmans@vortech.nl> (Maarten Bosmans's message of "Sun, 18 Feb 2024 20:59:34 +0100")
Maarten Bosmans <mkbosmans@gmail.com> writes:
> Subject: Re: [PATCH v2 1/5] log: Move show_blob_object() to log.c
"Move" -> "move".
> From: Maarten Bosmans <mkbosmans@gmail.com>
>
> From: Maarten Bosmans <maarten.bosmans@vortech.nl>
The earlier one is not needed. Please do not include such a line.
>
> This way it can be used outside of builtin/log.c.
> The next commit will make builtin/notes.c use it.
The resulting file is only about a small part of the implementation
detail of "show", and has very little to do with "log".
"show.c" that happens to house show_blob_object(), a "canonical" way
to display a blob object, with an anticipation that somebody may
want to expand it in the future to house the "canonical" way to
display a tag, a tree or a commit object, would be OK, though.
next prev parent reply other threads:[~2024-02-20 1:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 20:49 [PATCH 0/4] Speed up git-notes show Maarten Bosmans
2024-02-05 20:49 ` [PATCH 1/4] notes: print note blob to stdout directly Maarten Bosmans
2024-02-06 3:44 ` Junio C Hamano
2024-02-06 9:55 ` Maarten Bosmans
2024-02-06 17:52 ` Junio C Hamano
2024-02-13 8:00 ` Jeff King
2024-02-13 17:35 ` Junio C Hamano
2024-02-15 5:26 ` Jeff King
2024-02-16 6:25 ` Junio C Hamano
2024-02-17 5:16 ` Jeff King
2024-02-17 5:56 ` Junio C Hamano
2024-02-17 6:09 ` Jeff King
2024-02-15 7:46 ` Maarten Bosmans
2024-02-15 15:04 ` Jeff King
2024-02-17 12:45 ` Maarten Bosmans
2024-02-20 1:51 ` Jeff King
2024-02-15 7:41 ` Maarten Bosmans
2024-02-06 13:55 ` Kristoffer Haugsbakk
2024-02-05 20:49 ` [PATCH 2/4] notes: use exisisting function stream_blob_to_fd Maarten Bosmans
2024-02-05 22:00 ` Eric Sunshine
2024-02-05 20:49 ` [PATCH 3/4] notes: do not clean up right before calling die() Maarten Bosmans
2024-02-05 20:49 ` [PATCH 4/4] notes: use strbuf_attach to take ownership of the object contents Maarten Bosmans
2024-02-06 7:08 ` [PATCH 0/4] Speed up git-notes show Kristoffer Haugsbakk
2024-02-06 8:51 ` Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 0/5] " Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 1/5] log: Move show_blob_object() to log.c Maarten Bosmans
2024-02-20 1:22 ` Junio C Hamano [this message]
2024-02-20 1:59 ` Jeff King
2024-02-20 3:03 ` Junio C Hamano
2024-02-20 11:40 ` Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 2/5] notes: avoid launching a child process to show a note blob Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 3/5] notes: use existing function stream_blob_to_fd Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 4/5] notes: do not clean up right before calling die() Maarten Bosmans
2024-02-18 19:59 ` [PATCH v2 5/5] notes: use strbuf_attach to take ownership of the object contents Maarten Bosmans
2024-02-20 2:12 ` Jeff King
2024-02-20 7:42 ` Maarten Bosmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjzn0x72z.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=maarten.bosmans@vortech.nl \
--cc=mkbosmans@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.