All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Will Palmer <wmpalmer@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] test for '!' handling in rev-parse's named commits
Date: Wed, 03 Jun 2015 16:12:23 -0700	[thread overview]
Message-ID: <xmqq7frkwfmw.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqbngwwjbd.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 03 Jun 2015 14:52:54 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> The anticipation is to use another feature introducer after "/!" to
> enhance the matching, so that we can keep enhancing the syntax.
>
> cf. http://thread.gmane.org/gmane.comp.version-control.git/40460/focus=40477
>
> Using "/!Message" to match commits that do not match Message
> directly goes against that extensivility design.
>
> We need to always remind ourselves that our latest shiny new toy
> will not be the final new feature.  There always will be need to add
> yet another new thing, and we need to keep the door open for them.
>
> Perhaps
>
> 	/!-string	-> find commit without "string"
>
> or something?

Of course, as I do not think it is something people would do
regularly to look for a non-match, I do not necessarily think we
need a short-hand "/!-string".  Perhaps following the long-hand
syntax suggested in that old article, it may be sensible to start
with something more descriptive like

	/!(negative)string

to look for a commit that does not say "string", without the
short-hand form.  Only after we see that people find the feature
useful and find the need to use it frequently (if it ever happens,
that is), we can introduce "/!-string" as a short-hand form as a
follow-up patch.

Thanks.

  parent reply	other threads:[~2015-06-03 23:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 20:54 [PATCH 0/2] specify commit by negative pattern Will Palmer
2015-06-03 20:54 ` [PATCH 1/2] test for '!' handling in rev-parse's named commits Will Palmer
2015-06-03 21:52   ` Junio C Hamano
2015-06-03 22:44     ` Will Palmer
2015-06-04 17:09       ` Junio C Hamano
2015-06-03 23:12     ` Junio C Hamano [this message]
2015-06-03 20:54 ` [PATCH 2/2] object name: introduce '^{/!<negative pattern>}' notation Will Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7frkwfmw.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.