All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Will Palmer <wmpalmer@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] test for '!' handling in rev-parse's named commits
Date: Wed, 03 Jun 2015 14:52:54 -0700	[thread overview]
Message-ID: <xmqqbngwwjbd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1433364854-30088-2-git-send-email-wmpalmer@gmail.com> (Will Palmer's message of "Wed, 3 Jun 2015 21:54:13 +0100")

Will Palmer <wmpalmer@gmail.com> writes:

> Specifically, as documented: '^{/!Message}' should fail, as this syntax
> is currently reserved; while '^{!!Message}' should search for a commit
> whose message contains the string "!Message".

The /! sequence being reserved does not mean it was planned to be
used only for a single thing in the future, though.

Think of it as a syntax to introduce extended features, the first
use of which was this:

	/!!string	-> find commit with "!string"

The above is just one "feature" that the reserved syntax allows,
namely, "to find a string that begins with an exclamation mark".
The anticipation is to use another feature introducer after "/!" to
enhance the matching, so that we can keep enhancing the syntax.

cf. http://thread.gmane.org/gmane.comp.version-control.git/40460/focus=40477

Using "/!Message" to match commits that do not match Message
directly goes against that extensivility design.

We need to always remind ourselves that our latest shiny new toy
will not be the final new feature.  There always will be need to add
yet another new thing, and we need to keep the door open for them.

Perhaps

	/!-string	-> find commit without "string"

or something?

  reply	other threads:[~2015-06-03 21:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 20:54 [PATCH 0/2] specify commit by negative pattern Will Palmer
2015-06-03 20:54 ` [PATCH 1/2] test for '!' handling in rev-parse's named commits Will Palmer
2015-06-03 21:52   ` Junio C Hamano [this message]
2015-06-03 22:44     ` Will Palmer
2015-06-04 17:09       ` Junio C Hamano
2015-06-03 23:12     ` Junio C Hamano
2015-06-03 20:54 ` [PATCH 2/2] object name: introduce '^{/!<negative pattern>}' notation Will Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbngwwjbd.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.