From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: ふじを <ffjlabo@gmail.com>, git@vger.kernel.org
Subject: Re: Trailers Containing Underscore or Dot Characters
Date: Thu, 14 Nov 2024 07:31:20 +0900 [thread overview]
Message-ID: <xmqqa5e2ahqf.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD0_+=5xmw6y5qiO22KMZhExLyZ=5HRjYphLD66vt0LLNg@mail.gmail.com> (Christian Couder's message of "Wed, 13 Nov 2024 22:57:34 +0100")
Christian Couder <christian.couder@gmail.com> writes:
>> Date: Wed Nov 13 08:28:19 2024 +0300
>> Test
>> test_hoge: fuga:
>> test.hoge: fuga:
>> test-hoge: fuga
>> ```
>>
>> What's different between what you expected and what actually happened?
>>
>> The one for `--trailer "test-hoge: fuga"` is finished with nothing.
>> But The others for ones which have "_" or "." are finished with ":".
>
> Yeah, that's because '-' is allowed in trailer keys while '_' and '.' are not.
Thanks for responding.
I did not offhand recall seeing anywhere in our documentation set
that defines what a valid trailer key looks like, so I went and read
the interpret-trailers manual page and did not find any. For
example, is this a valid trailer line, even if we know '-' is
"allowed in trailer keys"?
-test: fuga
Is this a valid trailer line, when your configuration adds '-' to
the set of separator characters?
test- fuga
We do not even have an entry in the glossary for "trailer", and that
probably is the first thing we need to fix.
next prev parent reply other threads:[~2024-11-13 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 7:40 Trailers Containing Underscore or Dot Characters ふじを
2024-11-13 21:57 ` Christian Couder
2024-11-13 22:31 ` Junio C Hamano [this message]
2024-11-15 7:42 ` Patrick Steinhardt
2024-11-18 1:07 ` Junio C Hamano
2024-11-17 19:33 ` [PATCH] Documentation/glossary: describe "trailer" kristofferhaugsbakk
2024-11-18 0:40 ` Junio C Hamano
2024-11-18 7:32 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa5e2ahqf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=ffjlabo@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.